Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary optimizeFonts key from type #24563

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Remove unnecessary optimizeFonts key from type #24563

merged 2 commits into from
Apr 28, 2021

Conversation

sumanthratna
Copy link
Contributor

@sumanthratna sumanthratna commented Apr 28, 2021 •
edited
Loading

#21676 moved fontOptimization out of the experimental key of NextConfig to the top level, so it should be removed from the type

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 16.6s 16.8s ⚠️ +216ms
buildDurationCached 5.5s 5.1s -324ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Page Load Tests Overall increase ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.966 2.902 -0.06
/ avg req/sec 843.03 861.48 +18.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.732 1.611 -0.12
/error-in-render avg req/sec 1443.62 1552.17 +108.55
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary sumanthratna/next.js patch-1 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 20.5s 20.6s ⚠️ +80ms
buildDurationCached 7.6s 7.7s ⚠️ +33ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary sumanthratna/next.js patch-1 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 14.1s 14s -136ms
buildDurationCached 5.9s 5.8s -175ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sumanthratna/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.873 2.894 ⚠️ +0.02
/ avg req/sec 870.31 863.96 ⚠️ -6.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.65 1.7 ⚠️ +0.05
/error-in-render avg req/sec 1515.57 1470.57 ⚠️ -45
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.18 kB 7.18 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary sumanthratna/next.js patch-1 Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 02db522

@ijjk
Copy link
Member

ijjk commented Apr 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 15.5s 15.5s -26ms
buildDurationCached 5.1s 4.8s -299ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Page Load Tests Overall increase ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.702 2.695 -0.01
/ avg req/sec 925.29 927.62 +2.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.541 1.517 -0.02
/error-in-render avg req/sec 1621.89 1647.99 +26.1
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary sumanthratna/next.js patch-1 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 19.4s 19.2s -168ms
buildDurationCached 7.1s 7.1s -36ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary sumanthratna/next.js patch-1 Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ⚠️ +2 B
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
buildDuration 12.9s 13s ⚠️ +108ms
buildDurationCached 5.6s 5.4s -215ms
nodeModulesSize 46.7 MB 46.7 MB -62 B
Page Load Tests Overall increase ✓
vercel/next.js canary sumanthratna/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.752 2.617 -0.13
/ avg req/sec 908.37 955.32 +46.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.553 1.555 0
/error-in-render avg req/sec 1610.08 1607.71 ⚠️ -2.37
Client Bundles (main, webpack, commons)
vercel/next.js canary sumanthratna/next.js patch-1 Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.18 kB 7.18 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sumanthratna/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sumanthratna/next.js patch-1 Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary sumanthratna/next.js patch-1 Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary sumanthratna/next.js patch-1 Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 394fc5f

@kodiakhq kodiakhq bot merged commit a35dedb into vercel:canary Apr 28, 2021
@sumanthratna sumanthratna deleted the patch-1 branch April 29, 2021 01:38
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@sumanthratna
Remove unnecessary optimizeFonts key from type (vercel#24563)
9e88359 
vercel#21676 moved `fontOptimization` out of the experimental key of `NextConfig` to the top level, so it should be removed from the type

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sumanthratna @ijjk