-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploy buttons URLs #20834
Fix deploy buttons URLs #20834
Conversation
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 10.8s | 10.8s | -22ms |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.122 | 2.103 | -0.02 |
/ avg req/sec | 1177.86 | 1189.03 | +11.17 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.377 | 1.306 | -0.07 |
/error-in-render avg req/sec | 1815.46 | 1914.23 | +98.77 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 618 B | 618 B | ✓ |
withRouter.html gzip | 606 B | 606 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 12.7s | 13.2s | |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.751 | 1.786 | |
/ avg req/sec | 1427.92 | 1399.45 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.11 | 1.102 | -0.01 |
/error-in-render avg req/sec | 2252.94 | 2268.62 | +15.68 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 618 B | 618 B | ✓ |
withRouter.html gzip | 606 B | 606 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 10.6s | 10.6s | |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
This reverts commit 4962756.
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 8.9s | 8.9s | -45ms |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.771 | 1.741 | -0.03 |
/ avg req/sec | 1411.84 | 1436.17 | +24.33 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.136 | 1.105 | -0.03 |
/error-in-render avg req/sec | 2201.63 | 2262.05 | +60.42 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 618 B | 618 B | ✓ |
withRouter.html gzip | 606 B | 606 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 10.5s | 10.7s | |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 10.6s | 10.1s | -551ms |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.178 | 2.134 | -0.04 |
/ avg req/sec | 1148.04 | 1171.24 | +23.2 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.599 | 1.433 | -0.17 |
/error-in-render avg req/sec | 1563.22 | 1744.11 | +180.89 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 618 B | 618 B | ✓ |
withRouter.html gzip | 606 B | 606 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 12.1s | 12.6s | |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-4da49e8..fbbd.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucleray Found several more places that need to be updated:
- 2 deploy buttons on with-deta-base are not in the right format
- Missing
project-name=<EXAMPLE_NAME>&repository-name=<EXAMPLE_NAME>
- Missing
- 2 deploy buttons on with-graphql-faunadb are not in the right format
-
project-name=my-nextjs-guestbook&repository-name=my-nextjs-guestbook
should be right afterrepository-url
-
- 2 deploy buttons on with-mysql are not in the right format
-
project-name
should be right afterrepository-url
, and it’s usingrepo-name
instead ofrepository-name
(and should be afterproject-name
)
-
- deploy button on with-recoil is not in the right format
- Using
zeit/next.js
instead ofvercel/next.js
- Using
@chibicode The changes you mentioned should be fixed now. Note that the order of the query parameters is not important here, but I still changed it like you recommended since it's better for consistency, and it will be easier to write a regex to match them if they are in the same order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed duplicate repository-name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucleray Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucleray I also removed URL encoding of repository-url
on two places: fa41c9b
By doing so, every deploy URL (starting from /new/git/external
) has the format
https://vercel.com/new/git/external?repository-url=https://github.com/vercel/next.js/tree/canary/examples/<EXAMPLE_NAME>&project-name=<EXAMPLE_NAME>&repository-name=<EXAMPLE_NAME>
...which can now be verified on VSCode:
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 11s | 10.9s | -38ms |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.28 | 2.23 | -0.05 |
/ avg req/sec | 1096.53 | 1121.03 | +24.5 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.6 | 1.609 | |
/error-in-render avg req/sec | 1562.66 | 1553.39 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-1fee81a..2bb3.js gzip | 6.62 kB | 6.62 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
index.html gzip | 613 B | 613 B | ✓ |
link.html gzip | 618 B | 618 B | ✓ |
withRouter.html gzip | 605 B | 605 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
buildDuration | 13.2s | 13.1s | -100ms |
nodeModulesSize | 80.8 MB | 80.8 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
677f882d2ed8..89aa.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-1fee81a..2bb3.js gzip | 6.62 kB | 6.62 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-d979103..c5ff.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | lucleray/next.js update-deploy-buttons | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
Fix all deploy button URLs in the Next.js repo to follow the following format:
The detailed docs for the Deploy Button can be found here: https://vercel.com/docs/more/deploy-button.
Also updates legacy Vercel import flow URLs (starting with vercel.com/import or with vercel.com/new/project), to use the new vercel.com/new URLs.
For example, for the
hello-world
example:The URL is https://vercel.com/new/git/external?repository-url=https://github.com/vercel/next.js/tree/canary/examples/hello-world&project-name=hello-world&repository-name=hello-world
And the deploy button looks like this:
![Deploy with Vercel](https://camo.githubusercontent.com/20bea215d35a4e28f2c92ea5b657d006b087687486858a40de2922a4636301ab/68747470733a2f2f76657263656c2e636f6d2f627574746f6e)
For reference, I used the following regexes to search for the incorrect URLs