-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: remove legacy plugin system #20759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.797 | 2.87 | |
/ avg req/sec | 893.77 | 871.11 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.513 | 1.598 | |
/error-in-render avg req/sec | 1652.42 | 1564.46 |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.12 kB | 7.12 kB | -5 B |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
css-HASH.js gzip | 363 B | 363 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.52 kB | 9.52 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 390 B | 390 B | ✓ |
Overall change | 390 B | 390 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
index.html gzip | 609 B | 610 B | |
link.html gzip | 615 B | 614 B | -1 B |
withRouter.html gzip | 605 B | 604 B | -1 B |
Overall change | 1.83 kB | 1.83 kB | -1 B |
Diffs
Diff for 778-HASH.js
@@ -350,7 +350,7 @@
}
}
- var _interopRequireWildcard3 = __webpack_require__(862);
+ var _interopRequireWildcard = __webpack_require__(862);
var _interopRequireDefault = __webpack_require__(5318);
@@ -361,10 +361,6 @@
var _extends2 = _interopRequireDefault(__webpack_require__(7154));
- var _interopRequireWildcard2 = _interopRequireDefault(
- __webpack_require__(862)
- );
-
__webpack_require__(400);
var _react = _interopRequireDefault(__webpack_require__(7294));
@@ -381,9 +377,9 @@
var _isDynamic = __webpack_require__(3288);
- var querystring = _interopRequireWildcard3(__webpack_require__(4915));
+ var querystring = _interopRequireWildcard(__webpack_require__(4915));
- var envConfig = _interopRequireWildcard3(__webpack_require__(9186));
+ var envConfig = _interopRequireWildcard(__webpack_require__(9186));
var _utils = __webpack_require__(3937);
@@ -803,11 +799,7 @@
domainLocales: domainLocales,
isPreview: isPreview
}
- ); // call init-client middleware
-
- if (false) {
- }
-
+ );
renderCtx = {
App: CachedApp,
initial: true,
@@ -822,14 +814,14 @@
render(renderCtx);
return _context.abrupt("return", emitter);
- case 44:
+ case 43:
return _context.abrupt("return", {
emitter: emitter,
render: render,
renderCtx: renderCtx
});
- case 45:
+ case 44:
case "end":
return _context.stop();
}
@@ -927,9 +919,6 @@
err = renderErrorProps.err; // In development runtime errors are caught by our overlay
// In production we catch runtime errors using componentDidCatch which will trigger renderError
- if (false) {
- }
-
if (false) {
} // Make sure we log the error to the console, otherwise users can't track down issues.
Diff for index.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -58,7 +58,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Diff for link.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -63,7 +63,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -75,7 +75,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Diff for withRouter.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -58,7 +58,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
buildDuration | 19.7s | 19.9s | |
buildDurationCached | 7.6s | 6.9s | -672ms |
nodeModulesSize | 46.6 MB | 46.6 MB | -33.1 kB |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.12 kB | 7.12 kB | -5 B |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
css-HASH.js gzip | 363 B | 363 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.52 kB | 9.52 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 390 B | 390 B | ✓ |
Overall change | 390 B | 390 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_error.js | 1.39 MB | 1.39 MB | -1.65 kB |
404.html | 2.76 kB | 2.76 kB | ✓ |
500.html | 2.75 kB | 2.75 kB | ✓ |
amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
amp.html | 1.96 kB | 1.96 kB | ✓ |
css.html | 2.13 kB | 2.13 kB | ✓ |
hooks.html | 2.01 kB | 2.01 kB | ✓ |
index.js | 1.39 MB | 1.39 MB | -1.65 kB |
link.js | 1.45 MB | 1.45 MB | -1.65 kB |
routerDirect.js | 1.44 MB | 1.44 MB | -1.65 kB |
withRouter.js | 1.44 MB | 1.44 MB | -1.65 kB |
Overall change | 7.15 MB | 7.14 MB | -8.26 kB |
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.7s | |
buildDurationCached | 5.8s | 5.2s | -550ms |
nodeModulesSize | 46.6 MB | 46.6 MB | -33.1 kB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.759 | 2.89 | |
/ avg req/sec | 906.04 | 864.97 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.68 | 1.646 | -0.03 |
/error-in-render avg req/sec | 1487.79 | 1518.47 | +30.68 |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
677f882d2ed8..HASH.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.2 kB | 7.19 kB | -5 B |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 60.3 kB | 60.3 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
amp-HASH.js gzip | 536 B | 536 B | ✓ |
css-HASH.js gzip | 339 B | 339 B | ✓ |
hooks-HASH.js gzip | 887 B | 887 B | ✓ |
index-HASH.js gzip | 227 B | 227 B | ✓ |
link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
21c68fa65a48..217.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.36 kB | 9.36 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 419 B | 419 B | ✓ |
Overall change | 419 B | 419 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
index.html gzip | 612 B | 612 B | ✓ |
link.html gzip | 620 B | 620 B | ✓ |
withRouter.html gzip | 605 B | 605 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -350,7 +350,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
}
}
- var _interopRequireWildcard3 = __webpack_require__("284h");
+ var _interopRequireWildcard = __webpack_require__("284h");
var _interopRequireDefault = __webpack_require__("TqRt");
@@ -363,10 +363,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
- var _interopRequireWildcard2 = _interopRequireDefault(
- __webpack_require__("284h")
- );
-
__webpack_require__("0sNQ");
var _react = _interopRequireDefault(__webpack_require__("q1tI"));
@@ -383,9 +379,9 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
var _isDynamic = __webpack_require__("/jkW");
- var querystring = _interopRequireWildcard3(__webpack_require__("3WeD"));
+ var querystring = _interopRequireWildcard(__webpack_require__("3WeD"));
- var envConfig = _interopRequireWildcard3(__webpack_require__("yLiY"));
+ var envConfig = _interopRequireWildcard(__webpack_require__("yLiY"));
var _utils = __webpack_require__("g/15");
@@ -803,11 +799,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
domainLocales: domainLocales,
isPreview: isPreview
}
- ); // call init-client middleware
-
- if (false) {
- }
-
+ );
renderCtx = {
App: CachedApp,
initial: true,
@@ -822,14 +814,14 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
render(renderCtx);
return _context.abrupt("return", emitter);
- case 44:
+ case 43:
return _context.abrupt("return", {
emitter: emitter,
render: render,
renderCtx: renderCtx
});
- case 45:
+ case 44:
case "end":
return _context.stop();
}
@@ -927,9 +919,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
err = renderErrorProps.err; // In development runtime errors are caught by our overlay
// In production we catch runtime errors using componentDidCatch which will trigger renderError
- if (false) {
- }
-
if (false) {
} // Make sure we log the error to the console, otherwise users can't track down issues.
Diff for index.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -65,7 +65,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
Diff for link.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
Diff for withRouter.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -65,7 +65,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
ijjk
approved these changes
Apr 22, 2021
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
buildDuration | 15.5s | 14.9s | -551ms |
buildDurationCached | 5s | 4.7s | -372ms |
nodeModulesSize | 46.6 MB | 46.6 MB | -33.1 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.665 | 2.632 | -0.03 |
/ avg req/sec | 937.97 | 950 | +12.03 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.414 | 1.391 | -0.02 |
/error-in-render avg req/sec | 1767.89 | 1796.69 | +28.8 |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.12 kB | 7.12 kB | -5 B |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
css-HASH.js gzip | 363 B | 363 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.52 kB | 9.52 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 390 B | 390 B | ✓ |
Overall change | 390 B | 390 B | ✓ |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
index.html gzip | 609 B | 610 B | |
link.html gzip | 615 B | 614 B | -1 B |
withRouter.html gzip | 605 B | 604 B | -1 B |
Overall change | 1.83 kB | 1.83 kB | -1 B |
Diffs
Diff for 778-HASH.js
@@ -350,7 +350,7 @@
}
}
- var _interopRequireWildcard3 = __webpack_require__(862);
+ var _interopRequireWildcard = __webpack_require__(862);
var _interopRequireDefault = __webpack_require__(5318);
@@ -361,10 +361,6 @@
var _extends2 = _interopRequireDefault(__webpack_require__(7154));
- var _interopRequireWildcard2 = _interopRequireDefault(
- __webpack_require__(862)
- );
-
__webpack_require__(400);
var _react = _interopRequireDefault(__webpack_require__(7294));
@@ -381,9 +377,9 @@
var _isDynamic = __webpack_require__(3288);
- var querystring = _interopRequireWildcard3(__webpack_require__(4915));
+ var querystring = _interopRequireWildcard(__webpack_require__(4915));
- var envConfig = _interopRequireWildcard3(__webpack_require__(9186));
+ var envConfig = _interopRequireWildcard(__webpack_require__(9186));
var _utils = __webpack_require__(3937);
@@ -803,11 +799,7 @@
domainLocales: domainLocales,
isPreview: isPreview
}
- ); // call init-client middleware
-
- if (false) {
- }
-
+ );
renderCtx = {
App: CachedApp,
initial: true,
@@ -822,14 +814,14 @@
render(renderCtx);
return _context.abrupt("return", emitter);
- case 44:
+ case 43:
return _context.abrupt("return", {
emitter: emitter,
render: render,
renderCtx: renderCtx
});
- case 45:
+ case 44:
case "end":
return _context.stop();
}
@@ -927,9 +919,6 @@
err = renderErrorProps.err; // In development runtime errors are caught by our overlay
// In production we catch runtime errors using componentDidCatch which will trigger renderError
- if (false) {
- }
-
if (false) {
} // Make sure we log the error to the console, otherwise users can't track down issues.
Diff for index.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -58,7 +58,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Diff for link.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -63,7 +63,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -75,7 +75,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Diff for withRouter.html
@@ -7,7 +7,7 @@
<noscript data-n-css=""></noscript>
<link
rel="preload"
- href="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
as="script"
/>
<link
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ href="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
as="script"
/>
<link
@@ -58,7 +58,7 @@
src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
></script>
<script
- src="/_next/static/chunks/webpack-0a1b4b870eec9ff69aa0.js"
+ src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
async=""
></script>
<script
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/778-beda66f5c7a66f66c0be.js"
+ src="/_next/static/chunks/778-50ebd4b37c2baf22a527.js"
async=""
></script>
<script
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
buildDuration | 19.2s | 18.8s | -422ms |
buildDurationCached | 7.1s | 7.1s | |
nodeModulesSize | 46.6 MB | 46.6 MB | -33.1 kB |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
597-HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-HASH.js gzip | 7.12 kB | 7.12 kB | -5 B |
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-HASH.js gzip | 3.68 kB | 3.68 kB | ✓ |
amp-HASH.js gzip | 558 B | 558 B | ✓ |
css-HASH.js gzip | 363 B | 363 B | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 243 B | 243 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 336 B | 336 B | ✓ |
withRouter-HASH.js gzip | 334 B | 334 B | ✓ |
99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.52 kB | 9.52 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 390 B | 390 B | ✓ |
Overall change | 390 B | 390 B | ✓ |
Serverless bundles Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_error.js | 1.39 MB | 1.39 MB | -1.65 kB |
404.html | 2.76 kB | 2.76 kB | ✓ |
500.html | 2.75 kB | 2.75 kB | ✓ |
amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
amp.html | 1.96 kB | 1.96 kB | ✓ |
css.html | 2.13 kB | 2.13 kB | ✓ |
hooks.html | 2.01 kB | 2.01 kB | ✓ |
index.js | 1.39 MB | 1.39 MB | -1.65 kB |
link.js | 1.45 MB | 1.45 MB | -1.65 kB |
routerDirect.js | 1.44 MB | 1.44 MB | -1.65 kB |
withRouter.js | 1.44 MB | 1.44 MB | -1.65 kB |
Overall change | 7.15 MB | 7.14 MB | -8.25 kB |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
buildDuration | 13.4s | 13s | -341ms |
buildDurationCached | 5.5s | 5.5s | |
nodeModulesSize | 46.6 MB | 46.6 MB | -33.1 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.668 | 2.517 | -0.15 |
/ avg req/sec | 937.14 | 993.21 | +56.07 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.434 | 1.477 | |
/error-in-render avg req/sec | 1743.11 | 1692.93 |
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
677f882d2ed8..HASH.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.2 kB | 7.19 kB | -5 B |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 60.3 kB | 60.3 kB | -5 B |
Legacy Client Bundles (polyfills)
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
amp-HASH.js gzip | 536 B | 536 B | ✓ |
css-HASH.js gzip | 339 B | 339 B | ✓ |
hooks-HASH.js gzip | 887 B | 887 B | ✓ |
index-HASH.js gzip | 227 B | 227 B | ✓ |
link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
21c68fa65a48..217.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.36 kB | 9.36 kB | ✓ |
Client Build Manifests
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 419 B | 419 B | ✓ |
Overall change | 419 B | 419 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | Timer/next.js feat/plugins-v2 | Change | |
---|---|---|---|
index.html gzip | 612 B | 612 B | ✓ |
link.html gzip | 620 B | 620 B | ✓ |
withRouter.html gzip | 605 B | 605 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -350,7 +350,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
}
}
- var _interopRequireWildcard3 = __webpack_require__("284h");
+ var _interopRequireWildcard = __webpack_require__("284h");
var _interopRequireDefault = __webpack_require__("TqRt");
@@ -363,10 +363,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
var _extends2 = _interopRequireDefault(__webpack_require__("pVnL"));
- var _interopRequireWildcard2 = _interopRequireDefault(
- __webpack_require__("284h")
- );
-
__webpack_require__("0sNQ");
var _react = _interopRequireDefault(__webpack_require__("q1tI"));
@@ -383,9 +379,9 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
var _isDynamic = __webpack_require__("/jkW");
- var querystring = _interopRequireWildcard3(__webpack_require__("3WeD"));
+ var querystring = _interopRequireWildcard(__webpack_require__("3WeD"));
- var envConfig = _interopRequireWildcard3(__webpack_require__("yLiY"));
+ var envConfig = _interopRequireWildcard(__webpack_require__("yLiY"));
var _utils = __webpack_require__("g/15");
@@ -803,11 +799,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
domainLocales: domainLocales,
isPreview: isPreview
}
- ); // call init-client middleware
-
- if (false) {
- }
-
+ );
renderCtx = {
App: CachedApp,
initial: true,
@@ -822,14 +814,14 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
render(renderCtx);
return _context.abrupt("return", emitter);
- case 44:
+ case 43:
return _context.abrupt("return", {
emitter: emitter,
render: render,
renderCtx: renderCtx
});
- case 45:
+ case 44:
case "end":
return _context.stop();
}
@@ -927,9 +919,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
err = renderErrorProps.err; // In development runtime errors are caught by our overlay
// In production we catch runtime errors using componentDidCatch which will trigger renderError
- if (false) {
- }
-
if (false) {
} // Make sure we log the error to the console, otherwise users can't track down issues.
Diff for index.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -65,7 +65,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
Diff for link.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -70,7 +70,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
Diff for withRouter.html
@@ -22,7 +22,7 @@
/>
<link
rel="preload"
- href="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ href="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
as="script"
/>
<link
@@ -65,7 +65,7 @@
async=""
></script>
<script
- src="/_next/static/chunks/main-dac0a020e0203da21562.js"
+ src="/_next/static/chunks/main-fb9d661ad5d84eba2d12.js"
async=""
></script>
<script
This was referenced Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completely removes the old plugins implementation. This system was experimental, never documented, and actively discouraged from usage.
The removal motivation here is that these hooks did not work as expected, nor exposed the appropriate abstractions to "plug into" Next.js.
We will replace the old plugin system with a simplified implementation, which is TBD. Expect an RFC in the coming months.
Fixes #20755