[WIP] Only watch config file that exists on the level of source files #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! That's how I meant it. But why are you going two levels up from inside the pages directory (../..) instead of just one? Wouldn't that mean we're landing outside the project dir? |
|
Locally I had specified a pages directory in my |
|
Sweet! |
|
Thanks 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1486.
Will now only watch a
next.config.jsthat is on the level of the source files (adjacent to where/pages(or however named) lives).WIP tag because the second requirement in the issue: "[that we watch] on a lower level than the source files" is unclear.
@leo, does this imply that all directories "on a lower level" should be traversed for
next.config.js?