Add message for missing peerDependencies #1187
Conversation
bin/next
Outdated
| } | ||
| }) | ||
|
|
||
| if (peerDependencyUnavailable) { |
There was a problem hiding this comment.
eventually a dumb question, but do we actually need react in every case? what if we're using preact or inferno? <- never used them, but saw it in the example folder... do we still need react installed?
If we don't strictly require them we shouldn't kill the application here.
There was a problem hiding this comment.
@sakulstra I believe we do since react is still used server side. cc @arunoda
There was a problem hiding this comment.
@sakulstra the idea behind is to make that usecase even better precisely, by not being opinionated about what flavor of React (fiber vs non-fiber) we bundle, or even enabling alt-Reacts.
At the moment, however, we need to figure out how we do an alias for the Node side of things, so that we use the server-renderer of each package.
We might introduce alias in next.config.js for this purpose (see #767), but I wish we could avoid it. Maybe we need to figure out a better way to run webpack on the server code. cc @nkzawa @arunoda
There was a problem hiding this comment.
@sakulstra has a good point.
We still don't use preact in the server that's where we need it most.
Anyway, @timneutkens we shouldn't kill the process. Just warn them is what we needed.
There was a problem hiding this comment.
Sure thing, removing.
bin/next
Outdated
| // When 'npm link' is used it checks the clone location. Not the project. | ||
| require.resolve(dependency) | ||
| } catch (err) { | ||
| console.log(`${dependency} not found. Please install ${dependency} using 'npm install ${dependency}'`) |
|
@arunoda merged it in. |
Fixes #1180