Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action get me warn info "LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format" #68487

Closed
1 task done
luojiyin1987 opened this issue Aug 3, 2024 · 1 comment · Fixed by #68486
Labels
examples Issue/PR related to examples locked

Comments

@luojiyin1987
Copy link
Contributor

luojiyin1987 commented Aug 3, 2024

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

nothing , only about dockefile.

Which example does this report relate to?

https://github.com/vercel/next.js/blob/canary/examples/with-docker/Dockerfile

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

github action get me warn info

 1 warning found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 25)

Expected Behavior

ENV PORT 3000

should be

ENV PORT=3000

To Reproduce

ENV PORT 3000

should be

ENV PORT=3000
@luojiyin1987 luojiyin1987 added the examples Issue/PR related to examples label Aug 3, 2024
@luojiyin1987 luojiyin1987 changed the title github action get me warm info "LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format" github action get me warn info "LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format" Aug 4, 2024
devjiwonchoi added a commit that referenced this issue Aug 4, 2024
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?
github action get me warm info 
"1 warning found (use docker --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy
"ENV key value" format (line 25)"
 
### Why?

### How?

Closes NEXT-
Fixes #

-->
Closes #68487

---------

Co-authored-by: Jiwon Choi <[email protected]>
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant