Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable webpack 5 by default when there is no custom webpack config #23143

Closed
timneutkens opened this issue Mar 17, 2021 · 2 comments · Fixed by #22323 or #23810
Closed

Enable webpack 5 by default when there is no custom webpack config #23143

timneutkens opened this issue Mar 17, 2021 · 2 comments · Fixed by #22323 or #23810
Milestone
Iteration 19

Comments

@timneutkens
Copy link
Member

The webpack 5 support is ready to be enabled by default for apps that do not have custom webpack configuration. For users that do have custom webpack configuration we'll show a warning that they can upgrade to using webpack 5 but expect some breaking of their configuration. We're going to maintain backwards compat with webpack 4 for a while to give everyone the time to enable it.
@timneutkens timneutkens added this to the Iteration 18 milestone Mar 17, 2021
@timneutkens timneutkens mentioned this issue Mar 17, 2021
Merged
@timneutkens timneutkens reopened this Apr 6, 2021
@timneutkens timneutkens modified the milestones: Iteration 18, Iteration 19 Apr 8, 2021
timneutkens added a commit to timneutkens/next.js that referenced this issue Apr 8, 2021
@timneutkens
Enable webpack 5 by default for apps without custom webpack configura…
8017bc9 
…tion

Fixes vercel#23143
@timneutkens timneutkens mentioned this issue Apr 8, 2021
Merged
8 tasks
@dnakov
Copy link

dnakov commented Apr 8, 2021

@timneutkens I think the webpack 5/4 stuff (loadWebpackHook) is not supposed to run when NODE_ENV === 'production'. Is there a reason why it needs to?

@kodiakhq kodiakhq bot closed this as completed in #23810 Apr 12, 2021
kodiakhq bot pushed a commit that referenced this issue Apr 12, 2021
@timneutkens
Enable webpack5 by default (#23810)
2dba861 
- Enable webpack 5 by default for apps without custom webpack configuration

Fixes #23143



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@andresgutgon andresgutgon mentioned this issue Apr 15, 2021
Open
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this issue Apr 20, 2021
@timneutkens @SokratisVidros
Enable webpack5 by default (vercel#23810)
f650a9c 
- Enable webpack 5 by default for apps without custom webpack configuration

Fixes vercel#23143



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iteration 19
3 participants
@dnakov @timneutkens @balazsorban44