-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable webpack 5 by default when there is no custom webpack config #23143
Milestone
Comments
@timneutkens I think the webpack 5/4 stuff (loadWebpackHook) is not supposed to run when NODE_ENV === 'production'. Is there a reason why it needs to? |
kodiakhq bot
pushed a commit
that referenced
this issue
Apr 12, 2021
- Enable webpack 5 by default for apps without custom webpack configuration Fixes #23143 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this issue
Apr 20, 2021
- Enable webpack 5 by default for apps without custom webpack configuration Fixes vercel#23143 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The webpack 5 support is ready to be enabled by default for apps that do not have custom webpack configuration. For users that do have custom webpack configuration we'll show a warning that they can upgrade to using webpack 5 but expect some breaking of their configuration. We're going to maintain backwards compat with webpack 4 for a while to give everyone the time to enable it.
The text was updated successfully, but these errors were encountered: