chore: migrate to getSetCookie
#586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4d00ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
balazsorban44
force-pushed
the
chore/more-get-set-cookie
branch
from
e8c093d
to
cc10154
Compare
balazsorban44
commented
Sep 7, 2023
Comment on lines
2
to
3
| /** @deprecated use [`Headers#getSetCookie()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) instead */ | ||
| getAll?(key: 'set-cookie'): string[] |
There was a problem hiding this comment.
Should we drop getAll altogether as part of a major bump?
Kikobeats
approved these changes
Sep 7, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headers.raw()which was anode-fetchnon-spec API https://github.com/node-fetch/node-fetch/blob/main/src/headers.js#L202 and seems to be a remaindergetAll(), it was a non-spec version ofgetSetCookiesplitCookiesStringwhich was an implementation of splittingset-cookiestrings before eithergetSetCookieorgetAllexisted.toLowerCase()in some places, asHeadersshould already handle that