Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spiral marker not using custom marker + Fix Marker disappear #146

Closed
wants to merge 2 commits into from
Closed

Fix spiral marker not using custom marker + Fix Marker disappear #146

wants to merge 2 commits into from

Conversation

kperreau
Copy link

This is a PR fixing spiral marker not using custom marker.
And it fix marker hide/disappear some time refer to this issue: #129

@GunnarAK
Copy link

GunnarAK commented May 1, 2020

I have tried your pull-request in my project locally. Cloned it and imported it in my package.json (and some other tweaks to be able to install deps from outside the project root).

MapView renders fine, BUT now the markers don't even try to render before disappearing. Sometimes 1 sticks its head up, but disappears when I try to pan to it (not clicking on marker).

Reverting back to react-native-maps's MapView shows my markers (total 43).
I have tested both of the MapView components with my custom markers and the default ones from react-native-maps. No difference in rendering there.

This issue persists on the following Android devices for me:

  • Samsung Galaxy J2 (SM-J260F) - 1GB RAM
  • Samsung Galaxy S5 Neo (SM-G903F) - 2GB RAM
  • LG Nexus 5X - 1GB RAM
  • Sony Xperia Z2 Compact - 4GB RAM

Meanwhile it works perfectly on my OnePlus 6 with 8GB RAM (A6003) it has the same SoC as the Sony Xperia.
So this leads me to believe it's RAM-related but I might be blindsighted by the number. I don't have any other devices to test on.
tracksViewChanges is toggled via component state of every marker.

componentDidUpdate(prevProps: Props) {
  if (
    prevProps.station !== this.props.station // set true only when props changed
  ) {
    this.setState({ tracksViewChanges: true });
  } else if (this.state.tracksViewChanges) {
    // set to false immediately after rendering with tracksViewChanges is true
    this.setState({ tracksViewChanges: false });
  }
}

@venits
Copy link
Owner

venits commented May 5, 2020

Hi 👋
I released a new version of this module: 3.2.0. This change is there.
I had to make some additional changes.

Thank you for your contribution ❤️

@venits venits closed this May 5, 2020
@benov84
Copy link

benov84 commented May 15, 2020

Still not working for me, marker dissapers

@jackimatin
Copy link

any solution for this issue?

please help me...

@JAZzmiX
Copy link

JAZzmiX commented Nov 25, 2022

Still not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants