Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple spiderfier #135

Merged
merged 2 commits into from
May 5, 2020
Merged

Conversation

chetanparmar95
Copy link
Contributor

Hi @venits ,

I've added support for multiple spinner. You can see the attached file for the same. I had an issue with the same and fixed that for my client and decided to contribute the same.
Screenshot_20200131-120435

@chetanparmar95
Copy link
Contributor Author

@venits have you checked this?

@venits venits changed the base branch from master to types May 5, 2020 19:56
@venits venits merged commit 2d98215 into venits:types May 5, 2020
@venits
Copy link
Owner

venits commented May 5, 2020

Hi 👋
I released a new version of this module: 3.2.0. This change is there.

Thank you for your contribution ❤️

@chetanparmar95
Copy link
Contributor Author

Do you have any Idea why still 0+ contribution after merging second pull request, what wrong am I doing while creating pull request? @venits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants