Add support for waypoints and routes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3cur3
commented
Apr 12, 2022
Comment on lines
+88
to
+96
| defp optional_string(xml, element_type) do | ||
| el = xpath(xml, ~x"./#{element_type}") | ||
|
|
||
| defp optinal_string(maybe_string) when maybe_string == "", do: nil | ||
| defp optinal_string(maybe_string), do: maybe_string | ||
| if is_nil(el) do | ||
| nil | ||
| else | ||
| xpath(el, ~x"./text()"s) | ||
| end | ||
| end |
There was a problem hiding this comment.
I was getting an exception thrown when trying to query ./whatever/text() when the element in question didn't exist, so I moved to checking for the element, then asking for its text.
| {:sweet_xml, "~> 0.6.0"} | ||
| {:sweet_xml, "~> 0.7.0"} |
There was a problem hiding this comment.
For this library's purposes, I think 0.6.6 that we were using previously is actually compatible with 0.7.3, so we could potentially specify a broader supported range here, albeit at the cost of additional testing. 0.6.x is incompatible with a lot of libraries in the wild, including ExAws.
|
Nice one. Thanks for this PR. |
|
My pleasure, and thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to mirror the existing structure here (adding a field to the
Gpxstruct, and new structs for each of the types).I'm using it at work and it's handled all the test data we've thrown at it so far. 😄