Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractor #290

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Refractor #290

merged 2 commits into from
Dec 31, 2021

Conversation

nikhilmaske-2001
Copy link
Contributor

Bumped version: 0.25.0

The older behavior of the codebase doesn't send the file response when we have file and have not defined responseAsCaption.
The good behavior is to send the response in all condition (even when responseAsCaption is undefined)

This PR fixes the above issue as well as refractor some code which is also a TODO (as mentioned in the codebase)

Testing plan: Tested it with all 3 combinations of responseAsCaption (i.e true, false, undefined)
(Also tested with other combinations like only response for exact or partialMatch or noMatch)

@nikhilmaske-2001
Copy link
Contributor Author

@vasani-arpit This PR is a duplicate of PR #269 which was closed by stale bot and I am not able to reopen it. This PR is ready for review, please take a look at it.

@vasani-arpit vasani-arpit merged commit 6867dae into vasani-arpit:master Dec 31, 2021
vasani-arpit added a commit that referenced this pull request Aug 8, 2023
@vasani-arpit
Squashed commit of the following:
210093c 
commit 545eaf4
Author: vasani-arpit <[email protected]>
Date:   Wed May 24 11:48:47 2023 +0530

    0.38.0

commit fdb697b
Author: vasani-arpit <[email protected]>
Date:   Wed May 24 11:48:32 2023 +0530

    Updating version

commit 611b6df
Author: Arpit Vasani <[email protected]>
Date:   Mon Feb 13 16:21:18 2023 +0530

    version update and removed extra code

commit 4ec1db4
Author: Arpit Vasani <[email protected]>
Date:   Sun Jan 15 19:02:13 2023 +0000

    lib update

commit f82b2de
Author: Arpit Vasani <[email protected]>
Date:   Wed Nov 16 15:02:21 2022 +0530

    0.35.0

commit 375a251
Author: Arpit Vasani <[email protected]>
Date:   Wed Nov 16 15:01:58 2022 +0530

    lib update

commit bb2e81c
Author: Arpit Vasani <[email protected]>
Date:   Mon Oct 31 10:51:33 2022 +0530

    0.34.0

commit b43648e
Author: Arpit Vasani <[email protected]>
Date:   Mon Oct 31 10:51:21 2022 +0530

    updating WA lib

commit 76ab304
Merge: a524cf8 f5152bd
Author: Arpit Vasani <[email protected]>
Date:   Wed Oct 19 11:45:25 2022 +0530

    Merge pull request #335 from mnomanmemon/readme-update

    readme navigation links not working - fixed

commit f5152bd
Author: Arpit Vasani <[email protected]>
Date:   Wed Oct 19 11:42:00 2022 +0530

    0.33.0

commit 0df9e27
Author: Muhammad Noman <[email protected]>
Date:   Sun Oct 9 23:41:53 2022 +0500

    readme navigation links not working - fixed

    readme navigation links such as #preview, #features, #downloads, #technologies was not working. I fixed them

commit a524cf8
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 6 20:56:27 2022 +0530

    0.32.0

commit d06938d
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 6 20:56:19 2022 +0530

    fixes

commit d39fa62
Author: Arpit Vasani <[email protected]>
Date:   Fri Aug 12 18:04:44 2022 +0530

    0.31.0

commit 24e0f02
Author: Arpit Vasani <[email protected]>
Date:   Fri Aug 12 18:04:28 2022 +0530

    code formatting and media fix

commit 04366cc
Merge: 2758107 11dd8dd
Author: Arpit Vasani <[email protected]>
Date:   Mon Jul 18 15:07:24 2022 +0530

    Merge pull request #331 from zeel-codder/dev

    noMatch function

commit 11dd8dd
Merge: a048996 13dcd13
Author: Arpit Vasani <[email protected]>
Date:   Mon Jul 18 15:06:47 2022 +0530

    Merge branch 'dev' of https://github.com/zeel-codder/WBOT into dev

commit a048996
Author: Arpit Vasani <[email protected]>
Date:   Mon Jul 18 15:05:35 2022 +0530

    0.30.0

commit 13dcd13
Author: zeel-codder <[email protected]>
Date:   Fri Jul 15 17:18:59 2022 +0530

    fixed issue #330

commit 2758107
Merge: 1cf2cec 57258e8
Author: Arpit Vasani <[email protected]>
Date:   Wed Jul 13 14:14:27 2022 +0530

    Merge pull request #329 from vasani-arpit/dev

    v0.29.0

commit 57258e8
Author: Arpit Vasani <[email protected]>
Date:   Wed Jul 13 14:08:34 2022 +0530

    📃 docs update

commit c420d4c
Author: Arpit Vasani <[email protected]>
Date:   Wed Jul 13 12:52:57 2022 +0530

    0.29.0

commit cf38fac
Merge: 2059b4b ec1cb5c
Author: Arpit Vasani <[email protected]>
Date:   Wed Jul 13 12:49:06 2022 +0530

    Merge pull request #326 from zeel-codder/dev

    reply meesage as per bot.json file

commit ec1cb5c
Author: zeel-codder <[email protected]>
Date:   Fri Jun 17 14:57:31 2022 +0530

    update webhook

commit 4874c18
Author: zeel-codder <[email protected]>
Date:   Fri Jun 17 14:56:08 2022 +0530

    add webhook code

commit beb2d60
Author: Arpit Vasani <[email protected]>
Date:   Mon Jun 13 17:05:54 2022 +0000

    removing extra log

commit 9f281b4
Author: zeel-codder <[email protected]>
Date:   Sun Jun 12 00:47:30 2022 +0530

    test all docs/reply-logic tests , all are working fine

commit 4d79cba
Author: Arpit Vasani <[email protected]>
Date:   Fri Jun 10 11:21:33 2022 +0000

    adding webhook logic

commit 2a2921c
Author: Arpit Vasani <[email protected]>
Date:   Fri Jun 10 10:59:44 2022 +0000

    adding reply logic

commit 44f6b5b
Author: Arpit Vasani <[email protected]>
Date:   Fri Jun 10 09:54:21 2022 +0000

    adding comments

commit 778ac7f
Author: zeel-codder <[email protected]>
Date:   Wed Jun 8 18:15:03 2022 +0530

    variables is done

commit 83eebb7
Author: zeel-codder <[email protected]>
Date:   Wed Jun 8 17:34:09 2022 +0530

    isGroupReply is done

commit 560d921
Author: zeel-codder <[email protected]>
Date:   Tue Jun 7 19:21:18 2022 +0530

    add response,file and responseAsCaption function

commit 2059b4b
Author: Arpit Vasani <[email protected]>
Date:   Sat May 28 09:00:43 2022 +0000

    Adding codespaces and solving errors

commit 8aca6d3
Author: Arpit Vasani <[email protected]>
Date:   Wed May 18 18:22:17 2022 +0530

    big changes realated to #325

commit 60ef4b6
Author: Arpit Vasani <[email protected]>
Date:   Wed Apr 27 12:51:24 2022 +0530

    removing stale bot

commit 1cf2cec
Merge: 81ccc30 915af22
Author: Arpit Vasani <[email protected]>
Date:   Tue Feb 1 16:48:59 2022 +0530

    Merge pull request #305 from zeel-codder/master

    solve issue #303 and #304

commit 915af22
Author: Arpit Vasani <[email protected]>
Date:   Tue Feb 1 16:47:54 2022 +0530

    0.28.0

commit 9cb1996
Author: Arpit Vasani <[email protected]>
Date:   Tue Feb 1 16:47:29 2022 +0530

    error handling and refactoring

commit b637bc9
Author: Arpit Vasani <[email protected]>
Date:   Tue Feb 1 15:50:48 2022 +0530

    Revert "solve issue #303"

    This reverts commit e3102e5.

commit 61884f8
Author: zeel-codder <[email protected]>
Date:   Mon Jan 31 22:47:09 2022 +0530

    Allow external files for injection #304 #1

commit e3102e5
Author: zeel-codder <[email protected]>
Date:   Sat Jan 29 22:04:55 2022 +0530

    solve issue #303

commit 81ccc30
Author: Arpit Vasani <[email protected]>
Date:   Sat Jan 29 14:43:13 2022 +0530

    0.27.0

commit 80f1ed9
Author: zeel-codder <[email protected]>
Date:   Fri Jan 28 22:04:28 2022 +0530

    formate

commit c6f38c8
Author: zeel-codder <[email protected]>
Date:   Fri Jan 28 21:56:00 2022 +0530

    solve issue ##296

commit 6aa35bb
Author: zeel-codder <[email protected]>
Date:   Fri Jan 28 21:54:34 2022 +0530

    solve issue ##296

commit 6867dae
Merge: 2b2b333 3f4281a
Author: Arpit Vasani <[email protected]>
Date:   Fri Dec 31 15:34:36 2021 +0530

    Merge pull request #290 from nikhilmaske-2001/refractor

    Refractor

commit 3f4281a
Author: Nikhil Maske <[email protected]>
Date:   Mon Dec 27 14:00:13 2021 +0530

    0.26.0

commit 46e261e
Author: Nikhil Maske <[email protected]>
Date:   Thu Oct 21 18:31:05 2021 +0530

    Consider responseAsCaption to be false if it is undefined.

commit 2b2b333
Author: Arpit Vasani <[email protected]>
Date:   Mon Dec 20 20:24:36 2021 +0530

    updating stale values

commit bc99f9f
Author: Nikhil Maske <[email protected]>
Date:   Wed Dec 1 15:30:37 2021 +0530

    0.25.0

commit 2549c37
Author: Nikhil Maske <[email protected]>
Date:   Wed Dec 1 15:25:28 2021 +0530

    Fix the window change bug.

commit e8631e9
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 30 16:00:35 2021 +0530

    Fix window change bug.

commit ec796a3
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 30 15:15:22 2021 +0530

    Improve blur name feature.

commit acd1b8e
Author: Nikhil Maske <[email protected]>
Date:   Fri Nov 26 14:05:02 2021 +0530

    Used same selector everywhere and improve blurName().

commit 9299c4d
Author: Nikhil Maske <[email protected]>
Date:   Fri Nov 26 13:49:38 2021 +0530

    Added blur recent messages feature.

commit 4ba1c2c
Author: Nikhil Maske <[email protected]>
Date:   Fri Nov 26 13:41:03 2021 +0530

    Improved blurChats() and blurPhotos()

commit e934563
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 17 18:53:55 2021 +0530

    Improve the colors of smartreply suggestions buttons.

commit d5b41f6
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 17 15:03:08 2021 +0530

    Refractor some code and deleted useless console logs.

commit 09c048a
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 17 14:46:58 2021 +0530

    Replace .remove with css property display:none

commit 1551136
Author: Nikhil Maske <[email protected]>
Date:   Thu Nov 11 12:52:15 2021 +0530

    Some minor UI changes.

commit 23279b5
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 10 12:49:00 2021 +0530

    Added mouseover event for blur objects.

commit f58ca67
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 9 16:41:14 2021 +0530

    Remove useless css from style.css

commit a810ce9
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 9 16:32:42 2021 +0530

    Added dark mode feature option.

commit 789f12a
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 9 16:05:14 2021 +0530

    Improve the popup look.

commit 368c716
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 9 15:47:12 2021 +0530

    Change the location of the popup.

commit 6758cba
Merge: 4c037ca 8a2c840
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 9 15:15:16 2021 +0530

    Resolved merge conflicts.

commit 8a2c840
Merge: b5148ce 21b0825
Author: Arpit Vasani <[email protected]>
Date:   Mon Nov 8 14:36:15 2021 +0530

    Merge pull request #281 from nikhilmaske-2001/check

    Check for update (0.24.0)

commit 21b0825
Author: Nikhil Maske <[email protected]>
Date:   Mon Nov 8 14:23:54 2021 +0530

    0.24.0

commit ccec86c
Author: Nikhil Maske <[email protected]>
Date:   Mon Nov 8 14:23:46 2021 +0530

    Added new feature of checkForUpdate.

commit 095a658
Author: Nikhil Maske <[email protected]>
Date:   Mon Nov 8 14:21:54 2021 +0530

    Installed semver.

commit b5148ce
Merge: 8914ed8 9f8d155
Author: Arpit Vasani <[email protected]>
Date:   Sun Nov 7 00:40:12 2021 +0530

    Merge pull request #271 from nikhilmaske-2001/instant

    clicktosend: Send the message instantly. (0.23.0)

commit 4c037ca
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 3 11:56:54 2021 +0530

    blurPhoto feature added.

commit c7eb7e1
Author: Nikhil Maske <[email protected]>
Date:   Wed Nov 3 11:43:11 2021 +0530

    Blur photos feature added.

commit df5e99f
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 2 16:05:49 2021 +0530

    blurName feature added.

commit 8084303
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 2 15:58:25 2021 +0530

    Add function call for each checkbox.

commit 4dcb139
Author: Nikhil Maske <[email protected]>
Date:   Tue Nov 2 15:26:07 2021 +0530

    Show popup in pane-side div.

commit 36fc939
Author: Nikhil Maske <[email protected]>
Date:   Mon Nov 1 12:32:47 2021 +0530

    Popup not visible.

commit 9f8d155
Author: Nikhil Maske <[email protected]>
Date:   Sun Oct 24 13:42:49 2021 +0530

    0.23.0

commit cddeff0
Author: Nikhil Maske <[email protected]>
Date:   Sun Oct 24 11:10:45 2021 +0530

    clicktosend: Send the message instantly.

    Fixes #270.

commit 8914ed8
Merge: e309322 481be3d
Author: Arpit Vasani <[email protected]>
Date:   Thu Oct 21 13:53:09 2021 +0530

    Merge pull request #268 from nikhilmaske-2001/noMatch

    Cover the case of noMatch in processMessages. Fixes #257

commit 481be3d
Author: Nikhil Maske <[email protected]>
Date:   Wed Oct 20 17:29:23 2021 +0530

    0.22.0

commit 04c0033
Author: Nikhil Maske <[email protected]>
Date:   Tue Oct 19 17:43:20 2021 +0530

    processMessages: Improve the logic handling with noMatch.

    Checking exactMatch and PartialMatch is not enough to cover the case
    of noMatch. So added an else statement for the same that makes sure
    the noMatch case is fully covered.

    Fixes #257.

commit e309322
Merge: c0bfba5 93c6ee6
Author: Arpit Vasani <[email protected]>
Date:   Tue Oct 19 20:27:22 2021 +0530

    Merge pull request #267 from nikhilmaske-2001/docs

    docs: Improved the docs.

commit 93c6ee6
Author: Nikhil Maske <[email protected]>
Date:   Tue Oct 19 19:39:36 2021 +0530

    0.21.0

commit 66a7e08
Author: Nikhil Maske <[email protected]>
Date:   Tue Oct 19 19:39:10 2021 +0530

    docs: Updated the docs.

commit c0bfba5
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 7 18:08:41 2021 +0530

    0.20.0

commit 04ac6c2
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 7 18:08:16 2021 +0530

    🔨 smart reply

commit 7255ee9
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 7 18:04:46 2021 +0530

    🔨 click to send fix

commit f16f68e
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 7 17:57:37 2021 +0530

    adding individual webhook and image double message bug has been converted to a flag based feature. 😎

commit 5d6543a
Author: Arpit Vasani <[email protected]>
Date:   Tue Sep 7 12:22:24 2021 +0530

    supporting caption as well as message when image reply

commit 0daef61
Author: Arpit Vasani <[email protected]>
Date:   Mon Sep 6 17:53:45 2021 +0530

    adding file in zip

commit e2b406f
Merge: cc2edd8 73fc698
Author: Arpit Vasani <[email protected]>
Date:   Mon Sep 6 17:36:13 2021 +0530

    Merge pull request #250 from vasani-arpit/fix/git-ignore

    add linux* to gitignore

commit 73fc698
Author: Arpit Vasani <[email protected]>
Date:   Mon Sep 6 17:25:04 2021 +0530

    0.19.4

commit 5d471f6
Author: Arpit Vasani <[email protected]>
Date:   Mon Sep 6 17:24:49 2021 +0530

    adding another in gitignore

commit e187fff
Author: Pavan <[email protected]>
Date:   Sun Sep 5 14:11:41 2021 +0530

    add linux* to gitignore

commit cc2edd8
Author: Arpit Vasani <[email protected]>
Date:   Sun Aug 15 19:37:51 2021 +0530

    Fixing CSP

commit 5440d48
Author: Arpit Vasani <[email protected]>
Date:   Thu Jul 15 19:26:53 2021 +0530

    0.19.2

commit 9cfe384
Author: Arpit Vasani <[email protected]>
Date:   Thu Jul 15 19:26:40 2021 +0530

    fixing no match

commit c3a4818
Merge: 318c5d6 6683d4f
Author: Arpit Vasani <[email protected]>
Date:   Sat Jul 10 14:36:57 2021 +0530

    Merge pull request #241 from imkhubaibraza/new-whatsapp-update

    fixed WAPI is not defined

commit 318c5d6
Author: Arpit Vasani <[email protected]>
Date:   Sat Jul 10 14:35:19 2021 +0530

    0.19.1

commit 8044df1
Author: Arpit Vasani <[email protected]>
Date:   Sat Jul 10 14:34:50 2021 +0530

    adding support for new WA

commit 6683d4f
Author: Muhammad <[email protected]>
Date:   Fri Jul 9 23:32:54 2021 +0500

    fixed WAPI is not defined

commit 0f0eb1e
Author: Arpit Vasani <[email protected]>
Date:   Sat Jun 19 15:03:43 2021 +0530

    updating WS

commit 75cd496
Author: Arpit Vasani <[email protected]>
Date:   Sat Jun 19 15:01:51 2021 +0530

    0.19.0

commit 548d3c2
Author: Arpit Vasani <[email protected]>
Date:   Sat Jun 19 15:01:27 2021 +0530

    Sending base64 data of image in webhook

commit ed9c3af
Author: Arpit Vasani <[email protected]>
Date:   Sat Jun 19 13:54:09 2021 +0530

    resolving #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhilmaske-2001 @vasani-arpit