Add configuration option for dialects without multi row insert support #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be more appropriate to throw an error, because the statement will most likely fail anyways. I'd like to hear some opinions about this. |
|
Closing this out due to age and the existing difficulty of dealing with lack of support for various other features by specific databases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a configuration parameter (
SQLDialect.supportsMultiRowInsert) to support dialects that do not support multi row inserts (e.g. Oracle). This istrueby default. Iffalse, a warning will be logged once multiple rows are about to be inserted into the database within a single statement.