Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo & add missing 'with' argument label #980

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

fang-ling
Copy link
Contributor

fix typo ClientTokenReponse => ClientTokenResponse (réponse to response)

add missing with argument label in the initializer of SessionToken to fix "Incorrect argument label in call (have 'with:', expected 'user:')".

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fang-ling thanks for this! Since this is only code changes do you think you could update the translations as well? Thanks!

@fang-ling fang-ling requested a review from a team as a code owner May 20, 2024 15:11
@fang-ling
Copy link
Contributor Author

@0xTim thanks for the suggestions. All the translations have been updated.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label May 20, 2024
@0xTim 0xTim enabled auto-merge (squash) May 20, 2024 16:03
@0xTim 0xTim merged commit 0005a29 into vapor:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants