Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about DTO for parent relationship #965

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Add note about DTO for parent relationship #965

merged 3 commits into from
Feb 9, 2024

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Feb 9, 2024

No description provided.

@0xTim 0xTim requested a review from gwynne as a code owner February 9, 2024 18:40
@gwynne
Copy link
Member

gwynne commented Feb 9, 2024

I would prefer that we document DTOs as recommended for general use with Fluent models, not just specifically when relations are involved. The Codable considerations apply to all Fluent properties, just in less obvious fashion.

@0xTim
Copy link
Member Author

0xTim commented Feb 9, 2024

@gwynne I've expanded the DTO section on the main model page to make it clearer

@0xTim 0xTim enabled auto-merge (squash) February 9, 2024 19:12
@0xTim 0xTim merged commit 5170deb into main Feb 9, 2024
1 check passed
@0xTim 0xTim deleted the parent-dto branch February 9, 2024 21:08
@penny-for-vapor penny-for-vapor bot mentioned this pull request Feb 9, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants