Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing else to guard in docs #955

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add missing else to guard in docs #955

merged 1 commit into from
Dec 18, 2023

Conversation

wSedlacek
Copy link
Contributor

The code as is has a syntax error.

@gwynne
Copy link
Member

gwynne commented Dec 16, 2023

Nice catch!! Can you also fix the same issue in the translations of that file? It looks like most of them have the same problem.

gwynne
gwynne previously requested changes Dec 16, 2023
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@gwynne gwynne added invalid code Code sample not working. no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) labels Dec 16, 2023
@MahdiBM
Copy link
Contributor

MahdiBM commented Dec 16, 2023

Yeah i was going to ask about the translations too 😅 https://github.com/vapor/docs/tree/main/docs/basics

@wSedlacek
Copy link
Contributor Author

@gwynne Got the other translations fixed! Good eye!

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) December 18, 2023 16:51
@0xTim 0xTim merged commit e478d99 into vapor:main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid code Code sample not working. no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants