Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snippet in server.md #954

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Update snippet in server.md #954

merged 2 commits into from
Dec 13, 2023

Conversation

valeriyvan
Copy link
Contributor

Use makeServerConfiguration instead of deprecated forServer.

@valeriyvan
Update snippet server.md
17bb8c4 
Use `makeServerConfiguration` instead of deprecated `forServer`
0xTim
0xTim requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! As this is only a code change could you update the code blocks in the other translations? Basically the files with server.*.md

@valeriyvan
Update snippet in server.de.md, server.nl.md, server.zh.md
55209d0 
    Use `makeServerConfiguration` instead of deprecated `forServer`
@valeriyvan valeriyvan requested a review from a team as a code owner December 12, 2023 16:41
@valeriyvan
Copy link
Contributor Author

Thanks for the PR! As this is only a code change could you update the code blocks in the other translations? Basically the files with server.*.md

done

@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Dec 13, 2023
0xTim
0xTim approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) December 13, 2023 12:51
@0xTim 0xTim merged commit fafc8ba into vapor:main Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@ptoffy ptoffy ptoffy approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valeriyvan @0xTim @ptoffy