Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Code Fixes to apns.md #950

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Minor Code Fixes to apns.md #950

merged 3 commits into from
Nov 26, 2023

Conversation

abegehr
Copy link
Contributor

@abegehr abegehr commented Nov 24, 2023

Otherwise Xcode gives errors on latest version.

@abegehr
Minor Code Fixes to apns.md
1a15606 
Otherwise Xcode gives errors on latest version.
0xTim
0xTim requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the code in the other translations as well?

@abegehr abegehr requested a review from a team as a code owner November 25, 2023 16:34
@abegehr abegehr requested a review from 0xTim November 25, 2023 16:36
@abegehr
Copy link
Contributor Author

abegehr commented Nov 25, 2023

@0xTim, updated the other languages to the best of my knowledge with some support from google translate 😄

0xTim
0xTim approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Nov 26, 2023
@0xTim 0xTim enabled auto-merge (squash) November 26, 2023 02:43
@0xTim 0xTim merged commit ed51309 into vapor:main Nov 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abegehr @0xTim