Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align apns versions and imports #947

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Align apns versions and imports #947

merged 1 commit into from
Nov 16, 2023

Conversation

dannflor
Copy link
Contributor

Make sure that import APNSCore and from: "4.0.0" are present in all versions of apns.md in response to vapor/apns#54.

@dannflor dannflor requested review from a team, 0xTim and gwynne as code owners November 16, 2023 17:49
@dannflor dannflor added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Nov 16, 2023
0xTim
0xTim approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit 6738625 into main Nov 16, 2023
1 check passed
@0xTim 0xTim deleted the update-apns branch November 16, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannflor @0xTim