Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added post roundabout instruction when enter/exit roundabout maneuvers are combined #2454

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Added post roundabout instruction when enter/exit roundabout maneuvers are combined #2454

merged 4 commits into from
Jul 7, 2020

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Jul 6, 2020 •
edited
Loading

Issue

Added logic to have a post roundabout instruction when enter/exit roundabout maneuvers are combined

image

Tasklist

  • Update gurka tests
  • RAD tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Jul 6, 2020
mandeepsandhu
mandeepsandhu reviewed Jul 7, 2020
View reviewed changes
src/odin/maneuver.cc Outdated Show resolved Hide resolved
mandeepsandhu
mandeepsandhu previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mandeepsandhu mandeepsandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dgearhart dgearhart merged commit 051efa7 into master Jul 7, 2020
@dgearhart dgearhart deleted the roundabout_verbal_post branch July 7, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandeepsandhu mandeepsandhu mandeepsandhu left review comments

@danpaz danpaz Awaiting requested review from danpaz

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @mandeepsandhu