use auto cleanup for actor in node bindings #1439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node bindings weren't using the auto-cleanup function for the
actor_t
object. since we are most of the way through the request to pbf refactor this didnt matter too much, but some of the stuff in the refactor isnt all the way done. what this means is that for each request there is some state left around inthor::worker_t
for example. simultaneously,actor_t
defaults auto-cleanup tofalse
. by setting it totrue
we make sure to clear out this state on every request. this wont be a problem once request state lives in the pbf request object. for now we are in a bit of an in between where some of it is still within the worker classes