Add entity equipment support #254
Open
+516
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
requested changes
Feb 20, 2023
dyc3
reviewed
Feb 21, 2023
Co-authored-by: Carson McManus <[email protected]>
|
@dyc3 Thank you for the review! I've made some changes based on your recomendations |
|
Just quickly chiming in, I think the packet you're looking for to set the player's inventory is This is sent on first connect to initialize the player inventory, and I think |
|
@mymatsubara are you still working on this PR? |
|
@LeoDog896 I stopped working on it. Feel free to close it |
|
👍 I'll fork your valence fork to continue this PR. |
|
@LeoDog896 Thank you very much! If you got any question about the code, feel free to ask me. |
dyc3
pushed a commit
that referenced
this pull request
Oct 23, 2024
# Objective - make valence work with entity equipment (armor, main/off hand items) # Solution adds the crate `valence_equipment` that exposes the Equipment Plugin. every `LivingEntity` will have a `Equipment` Component. The Equipment plugin will NOT be compatible with the inventory by default (thats intended, as that makes it possible to use the equipment feature without the inventory feature + I do think there are probably use cases where you want to make players appear as having armor, although they dont have it in their inventory) This PR would add Events when entities are (un)loaded by a player (used for sending equipment once the player loads an entity). I do believe this might also be a useful feature outside of the equipment feature. used #254 as reference + stole example idea fixes #662 Opening as a draft for now (might refactor the updating/event emitting system). Let me know what you think of the Entity Load/Unload events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main additions:
ComponentcalledEquipmentwhich tracks entity's current equipment and if they have been modified.update_equipmentwhich sendsSetEquipmentpackets to all clients in view, when an entity with aEquipmentcomponent is modified.McEntity::write_init_packetsto also sendSetEquipmentpackets.random_equipment.rsexampleThese change only have cosmetic effect for now, but the
Equipmentcomponent can be also used when dealing with game logic when equipment data is required.Test Plan
Steps:
cargo test -p valence --tests(there is a unit test inequipment.rs)random_equipmentexample with:cargo run --example random_equipmentlocalhostMcEntitywill be assigned a random set of equipment every secondVideo of the
random_equipmentexampleMinecraft.1.19.3.-.Multiplayer.3rd-party.Server.2023-02-20.18-26-53.mp4
PROBLEM: As we can see from the video, our client only display equipment changes from other players, but not from our own player entity. This happens because the equipment of our player entity are tracked client-side, thus the
SetEquipmentpacket does have effect when theentity_idis equal to your player entity id. There might me another packet type which can be used for such case, but I'm not sure don't know which one 😞Related
Issue related: #223