Enabled state change should fire on attach and detach.

[caalador]

method should also check if the enabled state has actually
changed so we don't fire events when things stay the same.

---

This change is 

[gilberto-torrezan]

---

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

a discussion (no related file):
This is super important for Grid, since it resets the DataCommunicator every time the method is called.

---

Comments from Reviewable

[Legioth]

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

flow-server/src/main/java/com/vaadin/flow/component/ComponentUtil.java, line 268 at r1 (raw file):

            boolean enabled) {
        component.onEnabledStateChanged(enabled);
        component.getChildren().forEach(child -> child.onEnabledStateChanged(

What about grandchildren?

---

flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java, line 1111 at r1 (raw file):

    @Test // 3818
    public void enabledStateChangeOnAttachCalledForParentState() {

Also test that the `disabled

---

Comments from Reviewable

[Legioth]

flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java, line 1111 at r1 (raw file):

Previously, Legioth (Leif Åstrand) wrote…

Also test that the `disabled

I was trying to say that the attribute value should also be tested

---

Comments from Reviewable

[caalador]

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.

---

flow-server/src/main/java/com/vaadin/flow/component/ComponentUtil.java, line 268 at r1 (raw file):

Previously, Legioth (Leif Åstrand) wrote…

What about grandchildren?

Tested and work as they should.

---

flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java, line 1111 at r1 (raw file):

Previously, Legioth (Leif Åstrand) wrote…

I was trying to say that the attribute value should also be tested

Done.

---

Comments from Reviewable

[vaadin-bot]

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. Element.java#L116: Do not forget to remove this deprecated code someday.

[gilberto-torrezan]

---

Reviewed 3 of 4 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable