Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force page reload on re-sync with MPR #19422

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented May 21, 2024

Workaround for MPR & resynchronization being broken. If MPR is detected, a full page reload will be forced when resynchronization is requested.

Fixes vaadin/multiplatform-runtime#133

Copy link

github-actions bot commented May 21, 2024

Test Results

1 100 files  +12  1 100 suites  +12   1h 22m 21s ⏱️ + 8m 6s
7 038 tests +20  6 989 ✅ +20  49 💤 ±0  0 ❌ ±0 
7 374 runs  +35  7 315 ✅ +35  59 💤 ±0  0 ❌ ±0 

Results for commit 13f6264. ± Comparison against base commit 2568944.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
49 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov merged commit 135bcfe into main Jun 4, 2024
26 checks passed
@mshabarov mshabarov deleted the fix/reload-page-on-resync-with-mpr branch June 4, 2024 12:38
vaadin-bot pushed a commit that referenced this pull request Jun 4, 2024
* fix: force page reload on re-sync with MPR

* add missing mock in test
vaadin-bot pushed a commit that referenced this pull request Jun 4, 2024
* fix: force page reload on re-sync with MPR

* add missing mock in test
vaadin-bot added a commit that referenced this pull request Jun 4, 2024
* fix: force page reload on re-sync with MPR

* add missing mock in test

Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot added a commit that referenced this pull request Jun 4, 2024
* fix: force page reload on re-sync with MPR

* add missing mock in test

Co-authored-by: Teppo Kurki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detach on Flow client resync closes MprUI and Flow UI, causes page reload
3 participants