Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear preseved chain cache for inactive UI #19360

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: clear preseved chain cache for inactive UI #19360

merged 2 commits into from
May 15, 2024

Conversation

mcollovati
Copy link
Collaborator

Prevents potential memory leaks caused by UIs being retained by the preserve on refresh cache when the browser page is closed.

@mcollovati
fix: clear preseved chain cache for inactive UI
9fa4e08 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
@mcollovati mcollovati mentioned this pull request May 13, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

Test Results

1 104 files  + 1  1 104 suites  +1   1h 22m 27s ⏱️ +12s
7 016 tests + 6  6 967 ✅ + 8  49 💤 ±0  0 ❌  - 1 
7 389 runs  +15  7 330 ✅ +17  59 💤 ±0  0 ❌  - 1 

Results for commit 679b571. ± Comparison against base commit aa507e6.

♻️ This comment has been updated with latest results.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov requested a review from tltv May 13, 2024 11:37
@mshabarov mshabarov requested review from tepi and removed request for tltv May 13, 2024 11:39
@mcollovati mcollovati merged commit a7e41f6 into main May 15, 2024
26 checks passed
@mcollovati mcollovati deleted the fix/clear-inactive-ui-preserveonrefresh-cache branch May 15, 2024 09:04
vaadin-bot pushed a commit that referenced this pull request May 15, 2024
@mcollovati @vaadin-bot
fix: clear preseved chain cache for inactive UI (#19360)
5dc103d 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7e41f6
error: could not apply a7e41f6... fix: clear preseved chain cache for inactive UI (#19360)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7e41f6
error: could not apply a7e41f6... fix: clear preseved chain cache for inactive UI (#19360)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7e41f6
error: could not apply a7e41f6... fix: clear preseved chain cache for inactive UI (#19360)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7e41f6
error: could not apply a7e41f6... fix: clear preseved chain cache for inactive UI (#19360)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
da6ffd7 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
fb61501 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
vaadin-bot added a commit that referenced this pull request May 15, 2024
@vaadin-bot @mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (#19381)
4d2ddf3 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.

Co-authored-by: Marco Collovati <[email protected]>
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
877aa98 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
2d01b94 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
81e1beb 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
43b4433 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (CP: 24.3) (#…
b505b9f 
…19382)

Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (#19385)
32cbb22 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (#19383)
63291fb 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
mcollovati added a commit that referenced this pull request May 15, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (#19384)
61892d5 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 2.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7e41f6
error: could not apply a7e41f6... fix: clear preseved chain cache for inactive UI (#19360)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati added a commit that referenced this pull request May 28, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360)
e060936 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

mcollovati added a commit that referenced this pull request May 31, 2024
@mcollovati
fix: clear preseved chain cache for inactive UI (#19360) (#19475)
c0d6e07 
Prevents potential memory leaks caused by UIs being retained by the
preserve on refresh cache when the browser page is closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tepi tepi tepi approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.10 cherry-picked-23.3 cherry-picked-23.4 cherry-picked-23.5 cherry-picked-24.3 cherry-picked-24.4 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.alpha1 target/2.10 target/23.3 target/23.4 target/23.5 target/24.3 target/24.4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcollovati @vaadin-bot @tepi @TatuLund @mshabarov