Generate at build time the metadata for theme editor tests

[brunovianarezende]

Description

The theme editor tests need files describing what are the properties available for the user. This PR creates such files at build time, in the vaadin-dev-server project.

Type of change

• Bugfix
• [ X ] Feature

Checklist

• [ X ] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
• [ X ] I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• [ X ] New and existing tests are passing locally with my change.
• [ X ] I have performed self-review and corrected misspellings.

Additional for Feature type of change

• Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

[github-actions]

Test Results

1 007 files  ±0  1 007 suites  ±0   1h 4m 49s ⏱️ -22s
6 408 tests ±0  6 367 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 664 runs   - 1  6 616 ✔️  - 1  48 💤 ±0  0 ❌ ±0 

Results for commit cf63a75. ± Comparison against base commit 77768a7.

♻️ This comment has been updated with latest results.

[MarcinVaadin]

If they are generated at runtime I would not commit them into git. I would put them inside target/test-resources or similar. That way we do not have to push changes each time source TS metadata change.

They should have .json extension.

[brunovianarezende]

If they are generated at runtime I would not commit them into git. I would put them inside target/test-resources or similar. That way we do not have to push changes each time source TS metadata change.

I agree. I will try to move them to target/somewhere and see if I can get them, as you suggest.

They should have .json extension.

ok

[szolo]

@brunovianarezende your PR looks awesome! Just remove the metadata information, make sure that it is executed during build, rebase and we are good to go!

Thanks again for a hard and productive work :)

[brunovianarezende]

@brunovianarezende your PR looks awesome! Just remove the metadata information, make sure that it is executed during build, rebase and we are good to go!

Thanks again for a hard and productive work :)

thanks! I will see if I can do as suggested by Marcin and then update this PR.

[brunovianarezende]

In the last commit I:

1. removed the txt files from the repository
2. moved the created metadata files to vaadin-deve-server/src/main/resources/META-INF/metadata
3. added vaadin-deve-server/src/main/resources/META-INF/metadata to .gitignore, so the files won't be saved in the repository
4. changed the metadata files extension from '.txt' to '.json'
5. provided, in vaadin-dev-server, a utility class to read the metadata for a given component
6. changed test-theme-editor to use this utility class

[szolo]

In the last commit I:

1. removed the txt files from the repository
2. moved the created metadata files to vaadin-deve-server/src/main/resources/META-INF/metadata
3. added vaadin-deve-server/src/main/resources/META-INF/metadata to .gitignore, so the files won't be saved in the repository
4. changed the metadata files extension from '.txt' to '.json'
5. provided, in vaadin-dev-server, a utility class to read the metadata for a given component
6. changed test-theme-editor to use this utility class

These changes are good. I am approving them as well as the while PR. Please rebase and proceed with merge. Thank you!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information