Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove shadow root helpers #13409

Merged
merged 1 commit into from
Apr 4, 2022
Merged

test: remove shadow root helpers #13409

merged 1 commit into from
Apr 4, 2022

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Apr 1, 2022

update getting from shadowroot

mshabarov
mshabarov requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently missing ";" in the test codes.

@caalador caalador force-pushed the tests/update_tb branch 3 times, most recently from a6f377f to e11ea31 Compare April 1, 2022 12:25
@caalador
test: remove shadow root helpers
18e9514 
update getting from shadowroot
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@caalador caalador requested a review from mshabarov April 4, 2022 05:08
@mshabarov mshabarov merged commit add289a into 1.0 Apr 4, 2022
@mshabarov mshabarov deleted the tests/update_tb branch April 4, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalador @mshabarov @vaadin-bot