Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to use null from clients side with primitives #11948

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Sep 29, 2021

fixes #4062

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 8 issues

  1. MAJOR PublishedServerEventHandlerRpcHandler.java#L188: A "NullPointerException" could be thrown; "instance" is nullable here. rule
  2. MAJOR PublishedServerEventHandlerRpcHandler.java#L194: A "NullPointerException" could be thrown; "instance" is nullable here. rule
  3. MAJOR PublishedServerEventHandlerRpcHandler.java#L284: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  4. MINOR PublishedServerEventHandlerRpcHandler.java#L113: Remove this use of "PolymerServerEventHandlers"; it is deprecated. rule
  5. MINOR PublishedServerEventHandlerRpcHandler.java#L114: Remove this use of "PolymerServerEventHandlers"; it is deprecated. rule
  6. MINOR PublishedServerEventHandlerRpcHandler.java#L155: Replace this lambda with a method reference. rule
  7. MINOR PublishedServerEventHandlerRpcHandler.java#L305: Remove this use of "DeprecatedPolymerPublishedEventHandler"; it is deprecated. rule
  8. MINOR PublishedServerEventHandlerRpcHandler.java#L307: Remove this use of "DeprecatedPolymerPublishedEventHandler"; it is deprecated. rule

@mshabarov mshabarov changed the title fix: allow to use null from clients side with primitives feat: allow to use null from clients side with primitives Oct 1, 2021
@mshabarov mshabarov added +0.0.1 and removed +1.0.0 labels Oct 1, 2021
@mshabarov mshabarov enabled auto-merge (squash) October 1, 2021 13:02
@mshabarov mshabarov merged commit a4dec48 into master Oct 1, 2021
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha6 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert null to false for @ClientCallable booleans
3 participants