Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Download Atmosphere JS instead of having it in the project #11934

Merged
merged 1 commit into from
Sep 27, 2021
Merged

chore: Download Atmosphere JS instead of having it in the project #11934

merged 1 commit into from
Sep 27, 2021

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 27, 2021

No description provided.

@denis-anisimov
Copy link
Contributor

So it passes the all tests ?

How does it differ from #10582 which has a disabled IT to pass the validation?

@Artur-
Copy link
Member Author

Artur- commented Sep 27, 2021

This does not upgrade Atmosphere, it just generates the JS in the build instead of having a copy in the project

@denis-anisimov
Copy link
Contributor

Ah, I confused it with another PR. OK.

@denis-anisimov denis-anisimov merged commit bb04952 into master Sep 27, 2021
@denis-anisimov denis-anisimov deleted the atmosphere-dl branch September 27, 2021 10:14
@Artur- Artur- mentioned this pull request Sep 28, 2021
Merged
denis-anisimov pushed a commit that referenced this pull request Sep 29, 2021
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
4781e06 
…1934)
denis-anisimov pushed a commit that referenced this pull request Sep 29, 2021
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
43b7500 
…1934)
denis-anisimov pushed a commit that referenced this pull request Sep 29, 2021
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
6894cee 
…1934)
haijian-vaadin added a commit that referenced this pull request Sep 30, 2021
@haijian-vaadin
Revert "chore: Download Atmosphere JS instead of having it in the pro…
84bbbf2 
…ject (#11934)"

This reverts commit bb04952.
haijian-vaadin added a commit that referenced this pull request Sep 30, 2021
@haijian-vaadin
Revert atmosphere changes (#11953)
2e9d837 
* Revert "fix: Upgrade to Atmosphere 2.7.2 and Atmosphere JS 3.1.2 (#11935)"

This reverts commit e6459b3.

* Revert "chore: Download Atmosphere JS instead of having it in the project (#11934)"

This reverts commit bb04952.
pleku pushed a commit that referenced this pull request Oct 26, 2021
@Artur- @pleku
chore: Download Atmosphere JS instead of having it in the project (#1…
6e225b9 
…1934)
pleku pushed a commit that referenced this pull request Oct 26, 2021
@Artur- @pleku
chore: Download Atmosphere JS instead of having it in the project (#1…
e36a550 
…1934)
Artur- added a commit that referenced this pull request Nov 4, 2021
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
3ee4eed 
…1934)
Artur- added a commit that referenced this pull request Jan 14, 2022
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
1733688 
…1934)
Artur- added a commit that referenced this pull request Jan 17, 2022
@Artur-
chore: Download Atmosphere JS instead of having it in the project (#1…
5f2a755 
…1934) (#12727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artur- @denis-anisimov @vaadin-bot