Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture command error output #927

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

yujinqiu
Copy link
Contributor

@yujinqiu yujinqiu commented Mar 6, 2018

➜  a git:(master) ✗ ERROR=`cp c d`
cp: c: No such file or directory
➜  a git:(master) ✗ echo $?
1
➜  a git:(master) ✗ echo $ERROR

➜  a git:(master) ✗ ERROR=`cp c d 2>&1`
➜  a git:(master) ✗ echo $?
1
➜  a git:(master) ✗ echo $ERROR
cp: c: No such file or directory

According above test suggests ERROR is always EMPTY string if we don't capture command error output

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #927 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   75.52%   75.57%   +0.04%     
==========================================
  Files         206      206              
  Lines        9448     9448              
==========================================
+ Hits         7136     7140       +4     
+ Misses       1646     1642       -4     
  Partials      666      666
Impacted Files Coverage Δ
transport/internet/kcp/dialer.go 77.35% <0%> (-7.55%) ⬇️
transport/internet/kcp/io.go 59.09% <0%> (-4.55%) ⬇️
common/log/logger.go 84.37% <0%> (-3.13%) ⬇️
common/buf/writer.go 70.32% <0%> (-2.2%) ⬇️
transport/internet/kcp/listener.go 87% <0%> (-2%) ⬇️
transport/internet/kcp/sending.go 87.11% <0%> (-1.34%) ⬇️
transport/internet/kcp/connection.go 72.85% <0%> (-0.56%) ⬇️
proxy/vmess/outbound/outbound.go 79.77% <0%> (+1.12%) ⬆️
proxy/freedom/freedom.go 81.25% <0%> (+1.25%) ⬆️
transport/internet/headers/http/http.go 81.56% <0%> (+2.12%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1bb21...2dc6d29. Read the comment docs.

@DarienRaymond DarienRaymond merged commit 9ae3a68 into v2ray:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants