Show IP address when installation is done.

[Ariselia]

No description provided.

[codecov]

Codecov Report

Merging #787 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   75.03%   75.39%   +0.35%     
==========================================
  Files         188      188              
  Lines        8773     8773              
==========================================
+ Hits         6583     6614      +31     
+ Misses       1593     1565      -28     
+ Partials      597      594       -3

Impacted Files	Coverage Δ
transport/internet/websocket/connection.go	65.95% <0%> (-8.52%)	⬇️
transport/internet/headers/http/http.go	77.3% <0%> (-4.26%)	⬇️
app/proxyman/inbound/dynamic.go	68.26% <0%> (-1.93%)	⬇️
transport/internet/kcp/listener.go	74.54% <0%> (-1.82%)	⬇️
proxy/freedom/freedom.go	76.74% <0%> (-1.17%)	⬇️
proxy/socks/server.go	73.84% <0%> (-0.77%)	⬇️
proxy/socks/protocol.go	56.16% <0%> (-0.65%)	⬇️
proxy/vmess/encoding/server.go	72.81% <0%> (+0.92%)	⬆️
proxy/shadowsocks/client.go	76.69% <0%> (+0.97%)	⬆️
proxy/vmess/outbound/outbound.go	75.51% <0%> (+2.04%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35545cb...08019f4. Read the comment docs.

[DarienRaymond]

What are you trying to achieve? and why is this change related to the installation?

[Ariselia]

1. Will show servers' IP address on current session.

2. Can make the configures for clients easier(Don't need to copy servers' IP address from VPS's panel or so).

[xiaokangwang]

I recommend to use $(ip addr)/$(ifconfig) instead of external website.

This should able to decrease data expose.

[xiaokangwang]

It is highly likely that the user can know the external ip of vps, as one will need it to connect via ssh.

[xiaokangwang]

There are other things need to be considered: if the user is using a VPS within NAT, notably lowendspirit series and some vps in China, it can be really difficult for scripts to detect the IP correctly and check whether port is reachable, given no data exposed to 3rd-party.

[xiaokangwang]

Should any other tool or user relay on this script to deduce reachable address, this could be an issue that effect their effectiveness.

[DarienRaymond]

I don't think this is a necessary functionality for the installation script. User doesn't have to use the IP of the VPS for proxy connections. The IP displayed here may be misleading. If you need such functionality, you may wrap your own script and add any logic that suitable for your scenario.