Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Platform to Force an reevaluation #687

Closed
wants to merge 1 commit into from

Conversation

xiaokangwang
Copy link
Contributor

if the platform package imported V2Ray Core, then it must call this so that the
change made after init can be take into account.

if the package imported V2Ray Core, then it must call this so that the
change made after init can be take into account.
@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #687 into master will increase coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   71.48%   71.52%   +0.03%     
==========================================
  Files         188      188              
  Lines        8635     8639       +4     
==========================================
+ Hits         6173     6179       +6     
+ Misses       1898     1897       -1     
+ Partials      564      563       -1
Impacted Files Coverage Δ
common/platform/platform.go 61.29% <60%> (-1.68%) ⬇️
transport/internet/kcp/dialer.go 75.94% <0%> (-3.8%) ⬇️
proxy/shadowsocks/client.go 72.34% <0%> (-2.13%) ⬇️
proxy/shadowsocks/server.go 62.93% <0%> (-1.73%) ⬇️
transport/internet/kcp/receiving.go 97.45% <0%> (-1.28%) ⬇️
transport/internet/kcp/sending.go 90.13% <0%> (-0.9%) ⬇️
app/proxyman/mux/mux.go 70.29% <0%> (ø) ⬆️
transport/internet/kcp/connection.go 74.78% <0%> (+0.58%) ⬆️
proxy/socks/server.go 79.81% <0%> (+1.83%) ⬆️
app/proxyman/inbound/dynamic.go 70.19% <0%> (+1.92%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d34e7...e908e2b. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #687 into master will increase coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   71.48%   71.52%   +0.03%     
==========================================
  Files         188      188              
  Lines        8635     8639       +4     
==========================================
+ Hits         6173     6179       +6     
+ Misses       1898     1897       -1     
+ Partials      564      563       -1
Impacted Files Coverage Δ
common/platform/platform.go 61.29% <60%> (-1.68%) ⬇️
transport/internet/kcp/dialer.go 75.94% <0%> (-3.8%) ⬇️
proxy/shadowsocks/client.go 72.34% <0%> (-2.13%) ⬇️
proxy/shadowsocks/server.go 62.93% <0%> (-1.73%) ⬇️
transport/internet/kcp/receiving.go 97.45% <0%> (-1.28%) ⬇️
transport/internet/kcp/sending.go 90.13% <0%> (-0.9%) ⬇️
app/proxyman/mux/mux.go 70.29% <0%> (ø) ⬆️
transport/internet/kcp/connection.go 74.78% <0%> (+0.58%) ⬆️
proxy/socks/server.go 79.81% <0%> (+1.83%) ⬆️
app/proxyman/inbound/dynamic.go 70.19% <0%> (+1.92%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d34e7...e908e2b. Read the comment docs.

@DarienRaymond
Copy link
Contributor

Closing as it is no longer necessary.

@DarienRaymond DarienRaymond deleted the FixPlatfEnvReEval branch December 10, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants