fix timer leak

[ghv2]

The following code leads to timer leak. defer ticker.Stop() cannot stop the new ticker because of different addresses. The patch fixes this bug.

case timeout := <-t.timeout:
 			ticker.Stop()
 			ticker = time.NewTicker(timeout)

[codecov]

Codecov Report

Merging #587 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   71.83%   71.69%   -0.15%     
==========================================
  Files         185      185              
  Lines        8551     8553       +2     
==========================================
- Hits         6143     6132      -11     
- Misses       1854     1862       +8     
- Partials      554      559       +5

Impacted Files	Coverage Δ
common/signal/timer.go	100% <100%> (ø)	⬆️
transport/internet/websocket/connection.go	51.11% <0%> (-8.89%)	⬇️
common/buf/copy.go	60.41% <0%> (-8.34%)	⬇️
app/proxyman/mux/session.go	83.07% <0%> (-4.62%)	⬇️
proxy/vmess/outbound/outbound.go	77.27% <0%> (-2.28%)	⬇️
proxy/shadowsocks/server.go	62.93% <0%> (-1.73%)	⬇️
app/proxyman/mux/mux.go	68.64% <0%> (-0.85%)	⬇️
proxy/socks/protocol.go	55.01% <0%> (-0.65%)	⬇️
proxy/socks/server.go	77.98% <0%> (ø)	⬆️
transport/internet/kcp/connection.go	74.78% <0%> (+0.58%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b862365...0ef745d. Read the comment docs.

[DarienRaymond]

Thanks for noticing. The change is good. However, I prefer to keep 'defer' instead of using 'goto' or 'break'. For example:

defer func() {
  ticker.stop()
}()

POC: https://play.golang.org/p/BoNQU982zu

[DarienRaymond]

Thanks