Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UnregisterCounter method to stats manager #2208

Merged
merged 1 commit into from
Jun 28, 2020
Merged

add UnregisterCounter method to stats manager #2208

merged 1 commit into from
Jun 28, 2020

Conversation

remote-v2ray
Copy link
Contributor

No description provided.

@remote-v2ray
Copy link
Contributor Author

问题: 通过接口多次增加删除用户并且每次用户邮箱不一致的时候会导致内存泄露, 因为删除用户的时候没有删除 Counter, 添加这个接口可以手动清理 Counter , 使其维持在一定的数量内
应用: https://github.com/remote-v2ray/agent

@kslr kslr added the Next label Jun 27, 2020
@kslr kslr requested a review from xiaokangwang June 27, 2020 00:15
xiaokangwang
xiaokangwang approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this pr is ready to be merged.

@kslr kslr merged commit 4f7384c into v2ray:master Jun 28, 2020
@Vigilans Vigilans mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokangwang xiaokangwang xiaokangwang approved these changes

Assignees
No one assigned
Labels
Next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remote-v2ray @xiaokangwang @kslr