Reduce http proxy client overhead by 1RTT #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymous-Someneese
force-pushed
the
master
branch
5 times, most recently
from
c2dba49
to
65fd60b
Compare
added 4 commits
January 6, 2020 06:28
And any other protocol that require the connection initializer to send first, E.g. freedom with TFO.
Anonymous-Someneese
force-pushed
the
master
branch
from
65fd60b
to
e2b6080
Compare
|
Can anyone review this? |
Anonymous-Someneese
force-pushed
the
master
branch
from
a27032a
to
06431ae
Compare
vcptr
suggested changes
Jan 7, 2020
The HTTP changes would require connection initiator to send first or wait 5ms for HTTP CONNECT to send. The behaviour of bridge would be affected. |
|
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In standard HTTP proxy, client will wait until proxy connects to the destination and send 200 OK back. This introduce 1 RTT overhead. If we send the content right after writing the CONNECT command, this could be eliminated.
As for compatibility, a standard http proxy should be able to separate the command and content by \r\n\r\n. In my test, most proxy server can handle this behavior.
With this optimization, HTTPS proxy can have the same overhead as other TLS based protocols.