Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Makefile for core #2077

Closed
wants to merge 1 commit into from
Closed

add Makefile for core #2077

wants to merge 1 commit into from

Conversation

Yihen-Liu
Copy link

  1. add Makefile for cross compile
  2. add bin dir for binary generated by Makefile
  3. and demo config in bin/config

@vcptr
Copy link
Contributor

vcptr commented Dec 10, 2019

the project already has multiple compile tools under /release, and use bazel for ci release.
Another Makefile doesn't make much sense.
Btw, the project was supposed to compile with CGO_ENABLED=0

@Yihen-Liu
Copy link
Author

@vcptr thanks for your recommend. pull request closed immediately.

@Yihen-Liu Yihen-Liu closed this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yihen-Liu @vcptr