Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed call the Interrupt() after Close(), can't put MutilBuffer into pool. #1994

Closed
wants to merge 1 commit into from

Conversation

ansoda
Copy link

@ansoda ansoda commented Oct 31, 2019

Fixed call the Interrupt() after Close(), can't put MutilBuffer into pool.

@eycorsican
Copy link
Contributor

Perhaps you should change the state to errord before return

	if p.state == closed || p.state == errord {
                p.state = errord
		return
	}

otherwise you risk a nil pointer dereference here

if !p.data.IsEmpty() {

@github-actions
Copy link

github-actions bot commented Sep 3, 2020

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 3, 2020
@github-actions github-actions bot closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants