Add SO_REUSEPORT (kernel level load balance) support #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
using SO_REUSEPORT would improve UDP communicating performance. Good job! |
|
The PR would not solve the issue mentioned in #1881 since bindAddr() is only applied to outbound sockets (outbound sockets don't need SO_REUSEPORT), and has no effects on inbound sockets. Having that sort of workload needs SO_REUSEPORT are really rare cases, I don't think it's necessary, though applying bindAddr()/SO_REUSEADDR to both inbound and outbound sockets may solve the kind of issues mentioned in #1971, it's worth a try/fix. |
|
@eycorsican sorry for late reply. you are right, however i'm not a real Go developer. If you could let me know where is the right place to add the flag, i could help propose the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1881