Some code improvements #1750
Merged
Some code improvements #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sosiska
commented
Jun 14, 2019
•
sosiska
commented
- Rewrite empty string checks more idiomatically.
- Change strings.ToLower comparisons to strings.EqualFold.
- Rewrite switch statement with only one case as if.
|
|
You have bundled too many changes in a single commit and a single pull request. Some additional time is necessary for the maintenance team to analyze your change. |
Based on Russ Cox's comment in a golang-nuts topic:
|
proxy/mtproto/auth.go
Outdated
| @@ -83,7 +83,7 @@ func generateRandomBytes(random []byte, connType [4]byte) { | |||
| continue | |||
| } | |||
|
|
|||
| if 0x00000000 == (uint32(random[7])<<24)|(uint32(random[6])<<16)|(uint32(random[5])<<8)|uint32(random[4]) { | |||
There was a problem hiding this comment.
The original coding style can be used to prevent accidental assignment. While this is redundant in this case, this practice should be considered to be a beneficial one. Additional justification required for this change.
There was a problem hiding this comment.
I can reject it, if you want.
There was a problem hiding this comment.
Rejected in 0401a91
* Rewrite empty string checks more idiomatically. * Change strings.ToLower comparisons to strings.EqualFold. * Rewrite switch statement with only one case as if.
xiaokangwang
approved these changes
Jul 4, 2019
kslr
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.