Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read rest of buffer when any errors #1089

Closed
wants to merge 1 commit into from
Closed

Conversation

beyondkmp
Copy link

@beyondkmp beyondkmp commented May 4, 2018

当outbound遇到错误时,close pipe, 这样可以使pipe里面的数据读取完。如果直接closeerror的话,会清空整个pipe里面的内容,这样有点不太合理。标准库里面的read接口也是读取了多少数据就输出多少。fix #1082

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #1089 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   75.33%   75.39%   +0.06%     
==========================================
  Files         229      229              
  Lines       10074    10072       -2     
==========================================
+ Hits         7589     7594       +5     
+ Misses       1765     1755      -10     
- Partials      720      723       +3
Impacted Files Coverage Δ
app/proxyman/outbound/handler.go 70.14% <100%> (-0.87%) ⬇️
common/stats/io.go 71.42% <0%> (-28.58%) ⬇️
common/log/logger.go 84.37% <0%> (-3.13%) ⬇️
transport/internet/kcp/sending.go 87.11% <0%> (-1.34%) ⬇️
proxy/vmess/inbound/inbound.go 77.24% <0%> (+0.52%) ⬆️
app/proxyman/mux/mux.go 52.87% <0%> (+1.43%) ⬆️
app/proxyman/mux/session.go 83.56% <0%> (+12.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490afdc...8110efa. Read the comment docs.

@DarienRaymond
Copy link
Contributor

Already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

下载断流能重现
2 participants