Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a unitTest failure on windows #1053

Merged
merged 1 commit into from
Apr 14, 2018
Merged

fix a unitTest failure on windows #1053

merged 1 commit into from
Apr 14, 2018

Conversation

wuxiangzhou2010
Copy link
Contributor

@wuxiangzhou2010 wuxiangzhou2010 commented Apr 14, 2018

reproduced on go1.10 windows/amd64 , v2ray version : 3c2b75f

platform_test.go:55: Not true that (\v2ray\t) equals to (/v2ray/t)
--- FAIL: TestGetAssetLocation (0.00s)

@wuxiangzhou2010 wuxiangzhou2010 changed the title fix a test failure on windows fix a unitTest failure on windows Apr 14, 2018
@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #1053 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   75.17%   75.24%   +0.06%     
==========================================
  Files         226      226              
  Lines       10005    10005              
==========================================
+ Hits         7521     7528       +7     
+ Misses       1770     1764       -6     
+ Partials      714      713       -1
Impacted Files Coverage Δ
common/log/logger.go 84.37% <0%> (-3.13%) ⬇️
proxy/vmess/inbound/inbound.go 76.96% <0%> (-1.58%) ⬇️
transport/ray/direct.go 85.29% <0%> (-1.48%) ⬇️
proxy/shadowsocks/client.go 70.21% <0%> (+1.06%) ⬆️
transport/internet/headers/http/http.go 81.56% <0%> (+2.12%) ⬆️
common/buf/copy.go 76.47% <0%> (+7.84%) ⬆️
app/proxyman/mux/session.go 79.45% <0%> (+8.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2b75f...e986217. Read the comment docs.

@DarienRaymond DarienRaymond merged commit 296d3fa into v2ray:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants