-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install-release.sh将所有exit改为return,并在适当的地方增删return,目的是增加脚本可读性 #1041
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
=========================================
- Coverage 75.2% 75.1% -0.11%
=========================================
Files 225 225
Lines 9986 9986
=========================================
- Hits 7510 7500 -10
- Misses 1766 1773 +7
- Partials 710 713 +3
Continue to review full report at Codecov.
|
release/install-release.sh
Outdated
[[ "$CHECK" == "1" ]] && checkUpdate | ||
[[ "$REMOVE" == "1" ]] && remove | ||
[[ "$HELP" == "1" ]] && Help && return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把help放到check之后的用意是什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实没调顺序,checkUpdate后面也要加&& return的,是在另外一个pr里面提交的,所以这条只提交了Help和remove部分的修改,看上去好像的确改变顺序了。是否先合并了我再调整下?
PS:原来可以再调整的,我现在已经调整到原来的顺序了。
No description provided.