Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-release.sh将所有exit改为return,并在适当的地方增删return,目的是增加脚本可读性 #1041

Merged
merged 13 commits into from
Apr 12, 2018

Conversation

sunshineplan
Copy link
Contributor

No description provided.

@sunshineplan sunshineplan changed the title 5 将所有exit改为return,并在适当的地方增加return,目的是增加脚本可读性 Apr 12, 2018
@sunshineplan sunshineplan changed the title 将所有exit改为return,并在适当的地方增加return,目的是增加脚本可读性 将所有exit改为return,并在适当的地方增删return,目的是增加脚本可读性 Apr 12, 2018
@sunshineplan sunshineplan changed the title 将所有exit改为return,并在适当的地方增删return,目的是增加脚本可读性 install-release.sh将所有exit改为return,并在适当的地方增删return,目的是增加脚本可读性 Apr 12, 2018
@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1041 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1041      +/-   ##
=========================================
- Coverage    75.2%   75.1%   -0.11%     
=========================================
  Files         225     225              
  Lines        9986    9986              
=========================================
- Hits         7510    7500      -10     
- Misses       1766    1773       +7     
- Partials      710     713       +3
Impacted Files Coverage Δ
proxy/socks/client.go 72.15% <0%> (-2.54%) ⬇️
transport/internet/headers/http/http.go 79.43% <0%> (-2.13%) ⬇️
app/proxyman/mux/mux.go 54.83% <0%> (-1.62%) ⬇️
transport/internet/kcp/sending.go 87.11% <0%> (-1.34%) ⬇️
transport/ray/direct.go 86.76% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2d2ae...72e61b3. Read the comment docs.

[[ "$CHECK" == "1" ]] && checkUpdate
[[ "$REMOVE" == "1" ]] && remove
[[ "$HELP" == "1" ]] && Help && return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把help放到check之后的用意是什么?

Copy link
Contributor Author

@sunshineplan sunshineplan Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实没调顺序,checkUpdate后面也要加&& return的,是在另外一个pr里面提交的,所以这条只提交了Help和remove部分的修改,看上去好像的确改变顺序了。是否先合并了我再调整下?
PS:原来可以再调整的,我现在已经调整到原来的顺序了。

@DarienRaymond DarienRaymond merged commit 7f78775 into v2ray:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants