install-release.sh增加启动和停止服务失败的提醒 #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarienRaymond
requested changes
Apr 12, 2018
| @@ -186,6 +186,10 @@ stopV2ray(){ | |||
| elif [[ -n "${SERVICE_CMD}" ]] || [[ -f "/etc/init.d/v2ray" ]]; then | |||
| ${SERVICE_CMD} v2ray stop | |||
| fi | |||
| if [[ $? -ne 0 ]]; then | |||
| colorEcho ${RED} "Failed to shutdown V2Ray service." | |||
| return 2 | |||
There was a problem hiding this comment.
最好添加一下注释说明'2'的含义，或者统一整个脚本中返回值的含义，然后在文件开头处统一说明。
There was a problem hiding this comment.
已在开头出添加说明，由于pr比较分散，最后会再检查一遍。
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
=========================================
Coverage ? 75.21%
=========================================
Files ? 225
Lines ? 9986
Branches ? 0
=========================================
Hits ? 7511
Misses ? 1763
Partials ? 712Continue to review full report at Codecov.
|
DarienRaymond
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.