install-release.sh中copyFile功能简化 #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarienRaymond
requested changes
Apr 12, 2018
| @@ -222,12 +220,12 @@ makeExecutable() { | |||
| installV2Ray(){ | |||
| # Install V2Ray binary to /usr/bin/v2ray | |||
| mkdir -p /usr/bin/v2ray | |||
| copyFile v2ray true | |||
| copyFile v2ray || return $? | |||
There was a problem hiding this comment.
这个 return value 在调用的地方并没有处理。
There was a problem hiding this comment.
改好了，之前写在另外一个pr里面了
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
=========================================
Coverage ? 75.31%
=========================================
Files ? 225
Lines ? 9986
Branches ? 0
=========================================
Hits ? 7521
Misses ? 1756
Partials ? 709Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.