Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geolocation-cn: remove Google domain #85

Merged
merged 1 commit into from
Jul 27, 2020
Merged

geolocation-cn: remove Google domain #85

merged 1 commit into from
Jul 27, 2020

Conversation

akiirui
Copy link
Contributor

@akiirui akiirui commented Jul 27, 2020

google: Add attributes @cn to certain domain that available in China mainland

Ref: v2ray/domain-list-community#487 (comment)

google: Add attributes @cn to certain domain that available in China mainland
@Robot-DaneelOlivaw
Copy link
Contributor

You speak out my mind. It's more elegant to use @cn than listing all those domains in geolocation-cn. We should treat other similar domains in the same way.

By the way, it would be great if we could use attributes directly in the list. Then include:google@cn can be added back to geolocation-cn.

@akiirui
Copy link
Contributor Author

akiirui commented Jul 27, 2020

You speak out my mind. It's more elegant to use @cn than listing all those domains in geolocation-cn. We should treat other similar domains in the same way.

By the way, it would be great if we could use attributes directly in the list. Then include:google@cn can be added back to geolocation-cn .

Oh please don't add back to geolocation-cn. Because if user using DNS that outside China, received IP cannot directly access.

Maybe we can create a new category category-available-cn similar to category-ads. Integrate all domain from GFW sites but available in China.

@Robot-DaneelOlivaw
Copy link
Contributor

Oh please don't add back to geolocation-cn. Because if user using DNS that outside China, received IP cannot directly access.

So people don't use Chinese DNS for geolocation-cn? In this case, putting geolocation-!cn in front can override these domains.

With that said, users have to be familiar with domain lists to correctly configure. Leaving it out might be safer.

Anyway, it doesn't affect this PR.

Maybe we can create a new category category-available-cn similar to category-ads. Integrate all domain from GFW sites but available in China.

It's a great idea to manage these domains altogether. We'll have to see if this function will be deployed though. (And I might choose a different name for it.)

@Loyalsoldier Loyalsoldier merged commit 2411600 into v2fly:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants