Add --prepare option to migrate command #377
Conversation
| @@ -90,6 +90,11 @@ func migrateToKubernetes( | |||
| return utils.Errorf(err, L("cannot run migration")) | |||
| } | |||
|
|
|||
| if flags.Prepare { | |||
| log.Info().Msg(L("Migration prepared. Run the 'migrate' command without '--prepare' to finish the migration.")) | |||
There was a problem hiding this comment.
Should we scale to 0 after this? Is the migration without --prepare coping well with the existing resources?
There was a problem hiding this comment.
I have to test the kubernetes part.
There was a problem hiding this comment.
I have added scale to 0.
|
I if we set the prepare command we should stop just after the rsync of each volume. All the config changes (and probably the distribution copy) should be done only on final migrate. |
|
I think it is safe to let the migration scrip run till the end. All the config changes it does will be overwritten by the final run, but it can help to spot potential problems earlier, before stopping the old server. |
|
I have added kubernetes fixes - scale to 0 and skip traefik installation. |
What does this PR change?
This PR adds
--prepareoption tomigratecommand.With this option, the migration does not stop the services on source server and ends after syncing
the data.
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #181
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!