-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning Tuesday: Create dev container #229
Conversation
b031850
to
49fd009
Compare
@cbosdo , @rjmateus @juliogonzalez what do you think? I had this test with |
Is it possible to preload the go dependencies? they take a while to download. But that seems cool for newcomers. |
yes, it's possible, and it can be done in different ways: I just need to understand which is the best way for our scenario. This would be also more important for |
IIUC when you close the tab, the container will be idle and you can set |
it looks really cool :) |
I am testing this... how can we stop the codespace? :-D |
Not sure if I did it somehow, or I was just idle for enough time, but... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea looks cool! And I'd start implementing it here, and then I'd think of Uyuni as you told. And if for whatever reason we can't use it there, we can always use it here and at other repos.
See if you can preload go dependencies as Cedric requested.
But again, idea is great!
.github/PULL_REQUEST_TEMPLATE.md
Outdated
## Codespace | ||
<!-- Button to create CodeSpace --> | ||
|
||
[![Create CodeSpace](https://img.shields.io/badge/Create-CodeSpace-blue.svg)](https://codespaces.new/uyuni-project/uyuni-tools) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Cedric mention, see please add info about the prices, as it's relevant.
When I launched it, it told me my user was going to pay for it, in such case it means the standard limit for most users will be 180 core hours/month as explained at https://docs.github.com/en/billing/managing-billing-for-github-codespaces/about-billing-for-github-codespaces (and 15GB storage). Thats 22,5 days per month at 8 hours per day). Assuming the machine used has only one core, otherwise it's less.
If the user is Pro, then then more resources are assigned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also a link to the "getting started doc".
@@ -0,0 +1 @@ | |||
add devcontainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a changelog for this :-?
6ea7ec0
to
a7f138f
Compare
What does this PR change?
Example: mbussolotto#4: clicking on
Create Codespace
it's possible to create a golang container environment where compile, run unit test and change the code. Containertimeout
andretention
it's a user setting https://github.com/settings/codespaces.Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!