feat: minio adapter #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Commit amended to include fomatter/linter that somehow did not get included with inital commit.
haymaker
force-pushed
the
feat-minio-adapter
branch
from
22cd460
to
7adb89c
Compare
|
Closing, #76 supersedes this particular PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
FYI this is my first public PR on github.
See original PR at #51 - this PR rebases changes onto latest main and provides some tweaks to bring it in line with the current standard of what is already present in the repo.
I'm aware that there are other changes that you've requested and that this is possibly being refactored - I might be able to help with that in the future but for the moment I'm attempting to address a client need and wanted to contribute back.
Please let me know if any modifications or other issues need addressing.
Thanks!