Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BZIP2 compression algorithm #58

Closed
wants to merge 1 commit into from
Closed

Add BZIP2 compression algorithm #58

wants to merge 1 commit into from

Conversation

Luke-Shepp
Copy link

@Luke-Shepp Luke-Shepp commented Oct 7, 2022

Creates a new compression class to support BZIP2 compression and decompression, with accompanied unit test.

➜  utopia-php-storage git:(feat-bzip2-compression) ✗ ./vendor/bin/phpunit --filter BZIP2Test
PHPUnit 9.5.25 by Sebastian Bergmann and contributors.

....                                                                4 / 4 (100%)

Time: 00:01.870, Memory: 17.55 MB

OK (4 tests, 12 assertions)

Part 1 of appwrite/appwrite#3996

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Luke-Shepp Great PR! 🤯 We left some comments during the review, please check them out.

@@ -0,0 +1,74 @@
<?php

namespace Utopia\Tests;
Copy link
Contributor

@stnguyen90 stnguyen90 Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please use:

Suggested change
namespace Utopia\Tests;
namespace Utopia\Tests\Storage\Compression\Algorithms;

to match psr-4 standards?

@stnguyen90 stnguyen90 linked an issue Oct 18, 2022 that may be closed by this pull request
6 tasks
@stnguyen90
Copy link
Contributor

Also, it looks like the tests are failing:

image

@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@Meldiron
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@Luke-Shepp Luke-Shepp closed this by deleting the head repository Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗜️ Refine Appwrite Storage with bzip2 Compression
4 participants