Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 6378 AfricasTalking Messaging Adapter #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LunarMarathon
Copy link

@LunarMarathon LunarMarathon commented Oct 4, 2023

What does this PR do?

It implements the AfricasTalking Messaging Adapter.

Test Plan

  1. Create an account on https://africastalking.com/ (use the email and password option as the password is required for generating the API key in the next step)
  2. Click the "go to sandbox app" button on the dashboard -> settings -> API key, enter the password and generate the key.
  3. Open utopia-php/messaging root directory in a terminal.
  4. Run composer install to install PHPUnit and related packages.
  5. Set the following env vars: AFRICASTALKING_USERNAME, AFRICASTALKING_API_KEY, SMS_TO
    (SMS_TO must be a comma separated string of recipients' phone numbers. They need to be valid African numbers)
  6. Run the following command to test:
    vendor\bin\phpunit tests\e2e\SMS\AfricasTalkingTest.php
  7. The attached images show the test results:
    image
    image

Related PRs and Issues

Closes appwrite/appwrite#6378

Have you read the Contributing Guidelines on issues?

Yes.

@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

Copy link

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 Please make sure to run the formatter to fix the lint errors.

@tessamero
Copy link

@LunarMarathon

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💬 Improve Appwrite Messaging with AfricasTalking Adapter
4 participants